fix: remove use of ImagePromptTemplate in image handling and adds image utils #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
github-actions
bot
added
bug
italojohnny
approved these changes
Nov 8, 2024
dosubot
bot
added
lgtm
ogabrielluiz
force-pushed
the
fix-imageprompt
branch
from
517eacc
to
e0ca53d
Compare
…e with create_data_url function
…onversion and data URL creation
…on instead of `ImagePromptTemplate`
…dule - Introduce fixtures for temporary cache directory and sample image creation. - Add tests for message creation from human and AI text. - Implement tests for messages with single and multiple images. - Include tests for invalid image paths and messages without sender. - Add message serialization and conversion tests. - Ensure cleanup of cache directory after tests.
ogabrielluiz
force-pushed
the
fix-imageprompt
branch
from
89449d6
to
8e3c06b
Compare
CodSpeed Performance ReportMerging #4467 will not alter performanceComparing Summary
|
erichare
approved these changes
Nov 8, 2024
ogabrielluiz
added a commit
that referenced
this pull request
Nov 8, 2024
…ge utils (#4467) * remove poetry.lock * fix: update langchain-core dependency version to 0.3.15 * feat: add functions to convert images to base64 and create data URLs * refactor: simplify image URL handling by replacing ImagePromptTemplate with create_data_url function * Fix image URL structure in data schema to use nested dictionary format * Add unit tests for Data schema message conversion with text and images * test: add unit tests for image utility functions to validate base64 conversion and data URL creation * Refactor image URL generation to use `create_data_url` utility function instead of `ImagePromptTemplate` * Add unit tests for message handling and image processing in schema module - Introduce fixtures for temporary cache directory and sample image creation. - Add tests for message creation from human and AI text. - Implement tests for messages with single and multiple images. - Include tests for invalid image paths and messages without sender. - Add message serialization and conversion tests. - Ensure cleanup of cache directory after tests. * Use platformdirs to determine cache directory paths in test_schema_message.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the image URL handling by replacing the
ImagePromptTemplatewith a newcreate_data_urlfunction, which simplifies the process of generating data URLs for images. Additionally, it introduces functions to convert images to base64 format. Thelangchain-coredependency has been updated to version 0.3.15, and thepoetry.lockfile has been removed. These changes enhance the data schema for images and improve overall code maintainability.This fixes issues found in #4448