-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor langflow Components - Consolidate Imports, Remove Unused Components, and Update Astra Assistant Icons #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
labels
Nov 7, 2024
…mplify code and improve readability 🔧 (conftest.py): update imports to organize them alphabetically for better code maintenance 🔧 (test_starter_projects.py): organize imports alphabetically for better code maintenance 🔧 (test_astra_component.py): organize imports alphabetically for better code maintenance 🔧 (test_parse_json_data.py): remove unnecessary whitespace for cleaner code 🔧 (test_chat_input.py): remove unnecessary whitespace for cleaner code 🔧 (test_text_input.py): remove unnecessary whitespace for cleaner code 🔧 (test_output_parser.py): remove unnecessary whitespace for cleaner code 🔧 (test_chat_output.py): remove unnecessary whitespace for cleaner code 🔧 (test_text_output.py): remove unnecessary whitespace for cleaner code 🔧 (test_prompt.py): remove unnecessary whitespace for cleaner code 🔧 (test_basic_prompting.py): remove unnecessary whitespace for cleaner code 🔧 (test_misc.py): remove unnecessary whitespace for cleaner code 🔧 (utils.py): remove unnecessary whitespace for cleaner code 🔧 (test_server_init.py): remove unnecessary whitespace for cleaner code 🔧 (test_endpoints.py): remove unnecessary whitespace for cleaner code 🔧 (test_component_toolkit.py): remove unnecessary whitespace for cleaner code 🔧 (test_agent_component.py): remove unnecessary whitespace for cleaner code 🔧 (test_agent_events.py): remove unnecessary whitespace for cleaner code 🔧 (test_tool_calling_agent.py): remove unnecessary whitespace for cleaner code 🔧 (test_structured_output_component.py): remove unnecessary whitespace for cleaner code 🔧 (test_chatollama_component.py): remove unnecessary whitespace for cleaner code 📝 (test_huggingface.py): Remove unnecessary import statement 📝 (test_create_data_component.py): Remove unnecessary import statement 📝 (test_update_data_component.py): Remove unnecessary import statement 📝 (test_componet_set_functionality.py): Remove unnecessary import statement 📝 (test_component.py): Remove unnecessary import statement 📝 (test_event_manager.py): Remove unnecessary import statement 📝 (test_edge_base.py): Remove unnecessary import statement 📝 (test_state_model.py): Remove unnecessary import statement 📝 (test_base.py): Remove unnecessary import statement 📝 (test_callback_graph.py): Remove unnecessary import statement 📝 (test_cycles.py): Remove unnecessary import statement 📝 (test_graph_state_model.py): Remove unnecessary import statement 📝 (test_runnable_vertices_manager.py): Remove unnecessary import statement 📝 (test_utils.py): Remove unnecessary import statement 📝 (test_graph.py): Remove unnecessary import statement 📝 (test_base_model_from_schema.py): Reorder import statements 📝 (test_memory_chatbot.py): Remove unnecessary import statement 📝 (test_vector_store_rag.py): Remove unnecessary import statement 📝 (test_inputs.py): Reorder import statements 📝 (test_io_schema.py): Remove unnecessary import statement 📝 (test_table_schema.py): Remove unnecessary import statement 📝 (test_schema_message.py): Remove unnecessary import statement 📝 (test_service.py): Reorder import statements 📝 (test_api_key.py): Remove unnecessary import statement 📝 (test_chat_endpoint.py): Remove unnecessary import statement 📝 (test_cli.py): Remove unnecessary import statement 📝 (test_custom_component.py): Add missing import statement in test_custom_component.py 📝 (test_custom_component_with_client.py): Add missing import statement in test_custom_component_with_client.py 📝 (test_data_class.py): Add missing import statement in test_data_class.py 📝 (test_data_components.py): Add missing import statement in test_data_components.py 📝 (test_database.py): Add missing import statement in test_database.py 📝 (test_endpoints.py): Add missing import statement in test_endpoints.py 📝 (test_files.py): Add missing import statement in test_files.py 📝 (test_frontend_nodes.py): Add missing import statement in test_frontend_nodes.py 📝 (test_initial_setup.py): Add missing import statement in test_initial_setup.py 📝 (test_kubernetes_secrets.py): Add missing import statement in test_kubernetes_secrets.py 📝 (test_logger.py): Add missing import statement in test_logger.py 📝 (test_login.py): Add missing import statement in test_login.py 📝 (test_messages.py): Add missing import statement in test_messages.py 📝 (test_messages_endpoints.py): Add missing import statement in test_messages_endpoints.py 📝 (test_schema.py): Add missing import statement in test_schema.py 📝 (test_telemetry.py): Add missing import statement in test_telemetry.py 📝 (test_template.py): Add missing import statement in test_template.py 📝 (test_user.py): Add missing import statement in test_user.py 📝 (test_validate_code.py): Add missing import statement in test_validate_code.py 📝 (test_connection_string_parser.py): Add missing import statement in test_connection_string_parser.py 📝 (test_format_directory_path.py): Add missing import statement in test_format_directory_path.py 📝 (test_rewrite_file_path.py): Add missing import statement in test_rewrite_file_path.py 📝 (test_truncate_long_strings.py): Add missing import statement in test_truncate_long_strings.py 📝 (test_truncate_long_strings_on_objects.py): Add missing import statement in test_truncate_long_strings_on_objects.py
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Nov 8, 2024
…he application's UI for better test accuracy and reliability
…e readability and maintainability
CodSpeed Performance ReportMerging #4460 will degrade performances by 13.73%Comparing Summary
Benchmarks breakdown
|
…the skip flag to ensure it runs properly
…m LCVectorStoreComponent 🔧 (openai_tools.py): remove beta flag from OpenAIToolsAgentComponent 🔧 (tool_calling.py): remove beta flag from ToolCallingAgentComponent 🔧 (Vector Store RAG.json): remove 'cast_vector_store' method from starter projects 🔧 (styleUtils.ts): add missing icon 'WolframAlphaAPI' to nodeIconsLucide in styleUtils module
…t the first element with the specified test ID ♻️ (filterSidebar.spec.ts): remove unnecessary code related to checking the checkbox state in the test 🔧 (generalBugs-shard-2.spec.ts): update test to select the correct element with the test ID "dataWebhook" instead of "dataWebhook Input"
…store" value in both ingestion_graph and rag_graph functions to improve code readability and maintainability
…to 0.74.2 to resolve compatibility issues
…name 🐛 (generalBugs-shard-9.spec.ts): update endX calculation to move 600 pixels to the right instead of 300 🐛 (generalBugs-shard-9.spec.ts): fix typo in test case for component name and update test steps to click "fit_view" button twice
edwinjosechittilappilly
pushed a commit
that referenced
this pull request
Nov 11, 2024
…ed Components, and Update Astra Assistant Icons (#4460) * fix lint * fix lint * [autofix.ci] apply automated fixes * 📝 (message_to_data.py): refactor convert_message_to_data method to simplify code and improve readability 🔧 (conftest.py): update imports to organize them alphabetically for better code maintenance 🔧 (test_starter_projects.py): organize imports alphabetically for better code maintenance 🔧 (test_astra_component.py): organize imports alphabetically for better code maintenance 🔧 (test_parse_json_data.py): remove unnecessary whitespace for cleaner code 🔧 (test_chat_input.py): remove unnecessary whitespace for cleaner code 🔧 (test_text_input.py): remove unnecessary whitespace for cleaner code 🔧 (test_output_parser.py): remove unnecessary whitespace for cleaner code 🔧 (test_chat_output.py): remove unnecessary whitespace for cleaner code 🔧 (test_text_output.py): remove unnecessary whitespace for cleaner code 🔧 (test_prompt.py): remove unnecessary whitespace for cleaner code 🔧 (test_basic_prompting.py): remove unnecessary whitespace for cleaner code 🔧 (test_misc.py): remove unnecessary whitespace for cleaner code 🔧 (utils.py): remove unnecessary whitespace for cleaner code 🔧 (test_server_init.py): remove unnecessary whitespace for cleaner code 🔧 (test_endpoints.py): remove unnecessary whitespace for cleaner code 🔧 (test_component_toolkit.py): remove unnecessary whitespace for cleaner code 🔧 (test_agent_component.py): remove unnecessary whitespace for cleaner code 🔧 (test_agent_events.py): remove unnecessary whitespace for cleaner code 🔧 (test_tool_calling_agent.py): remove unnecessary whitespace for cleaner code 🔧 (test_structured_output_component.py): remove unnecessary whitespace for cleaner code 🔧 (test_chatollama_component.py): remove unnecessary whitespace for cleaner code 📝 (test_huggingface.py): Remove unnecessary import statement 📝 (test_create_data_component.py): Remove unnecessary import statement 📝 (test_update_data_component.py): Remove unnecessary import statement 📝 (test_componet_set_functionality.py): Remove unnecessary import statement 📝 (test_component.py): Remove unnecessary import statement 📝 (test_event_manager.py): Remove unnecessary import statement 📝 (test_edge_base.py): Remove unnecessary import statement 📝 (test_state_model.py): Remove unnecessary import statement 📝 (test_base.py): Remove unnecessary import statement 📝 (test_callback_graph.py): Remove unnecessary import statement 📝 (test_cycles.py): Remove unnecessary import statement 📝 (test_graph_state_model.py): Remove unnecessary import statement 📝 (test_runnable_vertices_manager.py): Remove unnecessary import statement 📝 (test_utils.py): Remove unnecessary import statement 📝 (test_graph.py): Remove unnecessary import statement 📝 (test_base_model_from_schema.py): Reorder import statements 📝 (test_memory_chatbot.py): Remove unnecessary import statement 📝 (test_vector_store_rag.py): Remove unnecessary import statement 📝 (test_inputs.py): Reorder import statements 📝 (test_io_schema.py): Remove unnecessary import statement 📝 (test_table_schema.py): Remove unnecessary import statement 📝 (test_schema_message.py): Remove unnecessary import statement 📝 (test_service.py): Reorder import statements 📝 (test_api_key.py): Remove unnecessary import statement 📝 (test_chat_endpoint.py): Remove unnecessary import statement 📝 (test_cli.py): Remove unnecessary import statement 📝 (test_custom_component.py): Add missing import statement in test_custom_component.py 📝 (test_custom_component_with_client.py): Add missing import statement in test_custom_component_with_client.py 📝 (test_data_class.py): Add missing import statement in test_data_class.py 📝 (test_data_components.py): Add missing import statement in test_data_components.py 📝 (test_database.py): Add missing import statement in test_database.py 📝 (test_endpoints.py): Add missing import statement in test_endpoints.py 📝 (test_files.py): Add missing import statement in test_files.py 📝 (test_frontend_nodes.py): Add missing import statement in test_frontend_nodes.py 📝 (test_initial_setup.py): Add missing import statement in test_initial_setup.py 📝 (test_kubernetes_secrets.py): Add missing import statement in test_kubernetes_secrets.py 📝 (test_logger.py): Add missing import statement in test_logger.py 📝 (test_login.py): Add missing import statement in test_login.py 📝 (test_messages.py): Add missing import statement in test_messages.py 📝 (test_messages_endpoints.py): Add missing import statement in test_messages_endpoints.py 📝 (test_schema.py): Add missing import statement in test_schema.py 📝 (test_telemetry.py): Add missing import statement in test_telemetry.py 📝 (test_template.py): Add missing import statement in test_template.py 📝 (test_user.py): Add missing import statement in test_user.py 📝 (test_validate_code.py): Add missing import statement in test_validate_code.py 📝 (test_connection_string_parser.py): Add missing import statement in test_connection_string_parser.py 📝 (test_format_directory_path.py): Add missing import statement in test_format_directory_path.py 📝 (test_rewrite_file_path.py): Add missing import statement in test_rewrite_file_path.py 📝 (test_truncate_long_strings.py): Add missing import statement in test_truncate_long_strings.py 📝 (test_truncate_long_strings_on_objects.py): Add missing import statement in test_truncate_long_strings_on_objects.py * [autofix.ci] apply automated fixes * formatting * Update import paths for MemoryComponent and HuggingFaceEndpointsComponent * fix tests * ✨ (decisionFlow.spec.ts): update test selectors to match changes in the application's UI for better test accuracy and reliability * [autofix.ci] apply automated fixes * ♻️ (test_output_parser.py): refactor import statements to improve code readability and maintainability * fix tests * ✅ (Simple Agent.spec.ts): enable test for "Simple Agent" by removing the skip flag to ensure it runs properly * [autofix.ci] apply automated fixes * Remove optional type from 'num_news' field in YahooFinanceSchema * Refactor JSON formatting for improved readability and maintainability across starter projects. * adding icon to flows * [autofix.ci] apply automated fixes * ✅ (similarity.spec.ts): update test selectors for filtering and connection nodes to match changes in the frontend implementation * [autofix.ci] apply automated fixes * removing init uncessary * ⬆️ (pyproject.toml): upgrade crewai dependency to version 0.76.9 to include the latest features and bug fixes * ✅ (Simple Agent.spec.ts): update test assertion to check if the count of "print(" is greater than or equal to 1 for better test coverage. * [autofix.ci] apply automated fixes * proposed changes * [autofix.ci] apply automated fixes * add zep icon * [autofix.ci] apply automated fixes * 🔧 (model.py): remove unused import and method 'cast_vector_store' from LCVectorStoreComponent 🔧 (openai_tools.py): remove beta flag from OpenAIToolsAgentComponent 🔧 (tool_calling.py): remove beta flag from ToolCallingAgentComponent 🔧 (Vector Store RAG.json): remove 'cast_vector_store' method from starter projects 🔧 (styleUtils.ts): add missing icon 'WolframAlphaAPI' to nodeIconsLucide in styleUtils module * add langwatch and mem0 icon * change mem0 name to mem0ai * ✨ (filterSidebar.spec.ts): update test to use first() method to select the first element with the specified test ID ♻️ (filterSidebar.spec.ts): remove unnecessary code related to checking the checkbox state in the test 🔧 (generalBugs-shard-2.spec.ts): update test to select the correct element with the test ID "dataWebhook" instead of "dataWebhook Input" * ♻️ (test_vector_store_rag.py): remove redundant code setting "vector_store" value in both ingestion_graph and rag_graph functions to improve code readability and maintainability * [autofix.ci] apply automated fixes * updating json test * [autofix.ci] apply automated fixes * ⬆️ (pyproject.toml): downgrade crewai dependency version from 0.76.9 to 0.74.2 to resolve compatibility issues * 🐛 (generalBugs-shard-5.spec.ts): fix typo in test case for component name 🐛 (generalBugs-shard-9.spec.ts): update endX calculation to move 600 pixels to the right instead of 300 🐛 (generalBugs-shard-9.spec.ts): fix typo in test case for component name and update test steps to click "fit_view" button twice --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several refactorings and updates to the
langflow
components, particularly focusing on consolidating imports, removing unused components, and updating icons for Astra Assistant components.Refactoring and Consolidation:
__init__.py
files inagents
andchains
directories to streamline the codebase.ToolCallingAgentComponent
andMemoryComponent
to reflect their new locations.Component Removal:
VectorStoreAgentComponent
class, including its dependencies and methods.Icon Updates: