Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: update firecrawl components #4458

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

italojohnny
Copy link
Member

@italojohnny italojohnny commented Nov 7, 2024

This PR updates firecrawl components.
Fixes #4450

@italojohnny italojohnny marked this pull request as ready for review November 11, 2024 19:51
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 11, 2024
@italojohnny italojohnny marked this pull request as draft November 11, 2024 19:51
@dosubot dosubot bot added the enhancement New feature or request label Nov 11, 2024
@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch 2 times, most recently from d9ee469 to 48f4062 Compare November 11, 2024 20:06
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4458 will degrade performances by 10.24%

Comparing feat/update-firecrawl-components (a78e175) with main (1dfa160)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/update-firecrawl-components Change
test_invalid_run_with_input_type_chat 16.5 ms 13.8 ms +19.17%
test_successful_run_with_input_type_text 394 ms 439 ms -10.24%
test_successful_run_with_output_type_debug 531.8 ms 456.7 ms +16.45%

@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch from 48f4062 to 72df179 Compare November 11, 2024 21:17
@italojohnny italojohnny marked this pull request as ready for review November 11, 2024 21:19
@italojohnny italojohnny enabled auto-merge (squash) November 12, 2024 13:51
@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch from 72df179 to 8932d73 Compare November 12, 2024 13:51
@italojohnny italojohnny added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch from 5c66f65 to f61ff7d Compare November 12, 2024 16:55
@italojohnny italojohnny removed the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch from f61ff7d to 615d342 Compare November 12, 2024 17:15
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch from e24a7a0 to 608aabb Compare November 12, 2024 19:26
@italojohnny italojohnny enabled auto-merge (squash) November 12, 2024 19:26
@italojohnny italojohnny force-pushed the feat/update-firecrawl-components branch from 608aabb to a78e175 Compare November 12, 2024 19:59
@ogabrielluiz ogabrielluiz merged commit 4f90552 into main Nov 12, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/update-firecrawl-components branch November 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with FirecrawlScrapeApi component in Langflow v1.0.19.post2
2 participants