Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nav bar UI, changed user menu to use shadcn dropdown, fix responsivity issues #4454

Merged
merged 14 commits into from
Nov 8, 2024

Conversation

lucaseduoli
Copy link
Collaborator

@lucaseduoli lucaseduoli commented Nov 7, 2024

This pull request focuses on updating the styling and structure of various components in the frontend application, specifically within the appHeaderComponent directory. The changes include modifying class names, updating component structures, and improving the overall user experience by refining the layout and appearance of elements.

Component Updates:

  • src/frontend/src/components/appHeaderComponent/components/FlowMenu/index.tsx:

    • Updated the "Saved" status text to use a more consistent style.
    • Adjusted the layout of the MenuBar component to improve alignment and spacing. [1] [2]
    • Changed the label from "Settings" to "Flow Settings" for clarity.
    • Improved the layout of the FlowSettingsModal and FlowLogsModal components.
  • src/frontend/src/components/appHeaderComponent/components/GithubStarButton/index.tsx:

    • Refined the styling of the GitHub star button for better visual consistency.
  • src/frontend/src/components/appHeaderComponent/components/HeaderMenu/index.tsx:

    • Replaced @headlessui/react Menu with a custom DropdownMenu component for better control over styling and behavior. [1] [2]
  • src/frontend/src/components/appHeaderComponent/components/ThemeButtons/index.tsx:

    • Updated theme button styles for better visual consistency and user experience. [1] [2]

General Layout Improvements:

  • src/frontend/src/components/appHeaderComponent/index.tsx:
    • Improved the layout and positioning of the header sections for better responsiveness and alignment. [1] [2] [3] [4] [5]

Style and Utility Updates:

  • src/frontend/src/components/ui/dropdown-menu.tsx:

    • Adjusted the DropdownMenuSeparator component to use a consistent border color.
  • src/frontend/src/pages/DashboardWrapperPage/index.tsx:

    • Simplified the layout structure for better compatibility with different screen sizes.
  • src/frontend/src/style/applies.css:

    • Removed redundant styles and improved the consistency of existing styles. [1] [2]
  • src/frontend/src/style/index.css:

    • Minor cleanup to remove unnecessary whitespace.
  • src/frontend/src/utils/styleUtils.ts:

    • Added new icon imports and updated the nodeIconsLucide object to include new icons. [1] [2] [3]

@lucaseduoli lucaseduoli self-assigned this Nov 7, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) November 7, 2024 19:40
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Nov 7, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 7, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@lucaseduoli lucaseduoli merged commit 6761df6 into main Nov 8, 2024
27 checks passed
@lucaseduoli lucaseduoli deleted the fix/nav_sweep branch November 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants