-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update nav bar UI, changed user menu to use shadcn dropdown, fix responsivity issues #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
javascript
Pull requests that update Javascript code
labels
Nov 7, 2024
anovazzi1
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ogabrielluiz
force-pushed
the
fix/nav_sweep
branch
from
November 7, 2024 20:37
5a0256d
to
58fedc9
Compare
ogabrielluiz
force-pushed
the
fix/nav_sweep
branch
from
November 8, 2024 13:32
58fedc9
to
0752dd0
Compare
ogabrielluiz
force-pushed
the
fix/nav_sweep
branch
from
November 8, 2024 16:29
a0f9c41
to
1916a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on updating the styling and structure of various components in the frontend application, specifically within the
appHeaderComponent
directory. The changes include modifying class names, updating component structures, and improving the overall user experience by refining the layout and appearance of elements.Component Updates:
src/frontend/src/components/appHeaderComponent/components/FlowMenu/index.tsx
:MenuBar
component to improve alignment and spacing. [1] [2]FlowSettingsModal
andFlowLogsModal
components.src/frontend/src/components/appHeaderComponent/components/GithubStarButton/index.tsx
:src/frontend/src/components/appHeaderComponent/components/HeaderMenu/index.tsx
:@headlessui/react
Menu
with a customDropdownMenu
component for better control over styling and behavior. [1] [2]src/frontend/src/components/appHeaderComponent/components/ThemeButtons/index.tsx
:General Layout Improvements:
src/frontend/src/components/appHeaderComponent/index.tsx
:Style and Utility Updates:
src/frontend/src/components/ui/dropdown-menu.tsx
:DropdownMenuSeparator
component to use a consistent border color.src/frontend/src/pages/DashboardWrapperPage/index.tsx
:src/frontend/src/style/applies.css
:src/frontend/src/style/index.css
:src/frontend/src/utils/styleUtils.ts
:nodeIconsLucide
object to include new icons. [1] [2] [3]