-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor loading of main page, use new Sidebar in main page, fix small UI bugs #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
This PR changes 1000+ lines, ignoring generated files.
label
Nov 7, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Nov 7, 2024
anovazzi1
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the frontend components and styles, particularly focusing on the
SideBarFoldersButtonsComponent
and related files. Key changes include refactoring import statements, modifying component props and states, and updating UI elements for better user experience and code maintainability.Component Refactoring and State Management:
src/frontend/src/components/folderSidebarComponent/components/sideBarFolderButtons/index.tsx
: Refactored to useuseLocation
forpathname
anduseFolderStore
forfolders
state. Removed redundant props and added new state management hooks. [1] [2]src/frontend/src/components/folderSidebarComponent/index.tsx
: Removed unused imports and simplified the component structure by removingHorizontalScrollFadeComponent
. [1] [2]UI and Styling Updates:
src/frontend/index.html
: Consolidated font import links into a single line for better readability.src/frontend/src/components/folderSidebarComponent/components/sideBarFolderButtons/index.tsx
: Updated various UI elements, including button variants, sidebar structure, and loading states. [1] [2]src/frontend/src/modals/templatesModal/components/TemplateCardComponent/index.tsx
: Modified background and icon styles for better visual feedback on hover and focus.API and Query Adjustments:
src/frontend/src/controllers/API/queries/flows/use-post-add-flow.ts
: Addedicon
property to theIPostAddFlow
interface and included it in the mutation payload. [1] [2]src/frontend/src/controllers/API/queries/folders/use-post-folders.ts
: ChangedonSettled
toonSuccess
in mutation options to ensure folders are refetched on successful post.Minor Fixes and Improvements:
src/frontend/src/components/folderSidebarComponent/components/sidebarFolderSkeleton/index.tsx
: Adjusted the skeleton loader height and padding for better alignment.src/frontend/src/pages/MainPage/components/dropdown/index.tsx
: Simplified the download menu item text.