fix: Improve Connection Line Styling and Cleanup Unused Code in FlowPage Components #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to dynamically set stroke and accent color based on handleDragging color ♻️ (PageComponent/index.tsx): refactor code to remove unused variables zoomIn, zoomOut, fitView, and zoom to improve code readability and maintainability
dosubot
bot
added
the
size:XS
mfortman11
approved these changes
Nov 7, 2024
joaoguilhermeS
pushed a commit
that referenced
this pull request
Nov 7, 2024
…age Components (#4449) ✨ (ConnectionLineComponent/index.tsx): introduce accentColor variable to dynamically set stroke and accent color based on handleDragging color ♻️ (PageComponent/index.tsx): refactor code to remove unused variables zoomIn, zoomOut, fitView, and zoom to improve code readability and maintainability Co-authored-by: Mike Fortman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
ConnectionLineComponentandPageComponentin theFlowPagedirectory. The main focus is on improving the visual representation of connection lines and cleaning up unused code.Changes to ConnectionLineComponent:
accentColorvariable to use HSL color based on the dragging state.strokestyle to useaccentColorinstead of the direct color value.strokeattribute of the circle element to useaccentColorinstead of the direct color value.Changes to PageComponent:
zoomIn,zoomOut,fitView, andzoomvariables.