-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed Pytest that uses Add Tool Output #4437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer required
edwinjosechittilappilly
requested review from
italojohnny,
ogabrielluiz and
jordanrfrazier
November 7, 2024 03:46
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 7, 2024
italojohnny
approved these changes
Nov 7, 2024
ogabrielluiz
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No longer required
ogabrielluiz
force-pushed
the
fix-remove-unwanted-pytest
branch
from
November 7, 2024 12:21
0114894
to
91fed30
Compare
…low-ai/langflow into fix-remove-unwanted-pytest
edwinjosechittilappilly
added a commit
that referenced
this pull request
Nov 7, 2024
* removed Pytest that uses Add Tool Output No longer required * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves significant changes to the unit tests for custom components in the backend. The primary focus is on removing certain fixtures and tests related to the
Component
class and its feature flags.These test no longer required with the update in how we use component as tools.
Key changes include:
Removal of Fixtures and Tests
src/backend/tests/unit/test_custom_component_with_client.py
: Removed thecode_component_with_multiple_outputs
andcode_component_with_multiple_outputs_with_add_tool_output
fixtures, which were responsible for setting up custom components with specific code.src/backend/tests/unit/test_custom_component_with_client.py
: Removed thetest_feature_flags_add_toolkit_output
test, which checked the behavior of theadd_tool_output
feature flag in custom components.