-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change Beta Tag and UI Enhancements for Node Components #4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r handling of beta features 📝 (NodeStatus/index.tsx): Import Badge component and add beta badge for beta nodes 📝 (GenericNode/index.tsx): Import Badge component and add beta badge for beta nodes 📝 (nodeToolbarComponent/index.tsx): Add border styling to nodeToolbarComponent for better visual separation 📝 (index.css): Update accent-pink and accent-pink-foreground colors for better contrast
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
javascript
Pull requests that update Javascript code
labels
Nov 5, 2024
anovazzi1
requested changes
Nov 5, 2024
…erly handled when data.node is undefined or null
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Nov 5, 2024
… into cz/components-sweep
anovazzi1
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
joaoguilhermeS
pushed a commit
that referenced
this pull request
Nov 7, 2024
📝 (NodeName/index.tsx): Add beta prop to NodeName component for better handling of beta features 📝 (NodeStatus/index.tsx): Import Badge component and add beta badge for beta nodes 📝 (GenericNode/index.tsx): Import Badge component and add beta badge for beta nodes 📝 (nodeToolbarComponent/index.tsx): Add border styling to nodeToolbarComponent for better visual separation 📝 (index.css): Update accent-pink and accent-pink-foreground colors for better contrast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
NodeName
,NodeStatus
, andGenericNode
components, along with some style adjustments. The main changes include adding support for beta nodes, updating UI elements, and refining CSS variables for better theming.Support for Beta Nodes:
beta
property to theNodeName
component and adjusted the class names to reflect the beta status. [1] [2]NodeStatus
component to display a "BETA" badge when the node is in beta status.GenericNode
component to pass thebeta
property and display a shadow effect on hover. [1] [2] [3]UI Enhancements:
Badge
component to theNodeStatus
andGenericNode
components for better visual indication of beta nodes. [1] [2]NodeStatus
component for better alignment and readability. [1] [2] [3]Style Adjustments:
--accent-pink
and--accent-pink-foreground
to improve color contrast and consistency.NodeToolbarComponent
for a more defined look.