Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change Beta Tag and UI Enhancements for Node Components #4417

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request introduces several updates to the NodeName, NodeStatus, and GenericNode components, along with some style adjustments. The main changes include adding support for beta nodes, updating UI elements, and refining CSS variables for better theming.

Support for Beta Nodes:

  • Added a beta property to the NodeName component and adjusted the class names to reflect the beta status. [1] [2]
  • Updated the NodeStatus component to display a "BETA" badge when the node is in beta status.
  • Modified the GenericNode component to pass the beta property and display a shadow effect on hover. [1] [2] [3]

UI Enhancements:

  • Added a Badge component to the NodeStatus and GenericNode components for better visual indication of beta nodes. [1] [2]
  • Improved the layout and spacing within the NodeStatus component for better alignment and readability. [1] [2] [3]

Style Adjustments:

  • Updated CSS variables for --accent-pink and --accent-pink-foreground to improve color contrast and consistency.
  • Added a border to the NodeToolbarComponent for a more defined look.

…r handling of beta features

📝 (NodeStatus/index.tsx): Import Badge component and add beta badge for beta nodes
📝 (GenericNode/index.tsx): Import Badge component and add beta badge for beta nodes
📝 (nodeToolbarComponent/index.tsx): Add border styling to nodeToolbarComponent for better visual separation
📝 (index.css): Update accent-pink and accent-pink-foreground colors for better contrast
@Cristhianzl Cristhianzl self-assigned this Nov 5, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Nov 5, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 5, 2024 21:31
…erly handled when data.node is undefined or null
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 5, 2024
@anovazzi1 anovazzi1 self-requested a review November 5, 2024 21:35
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@Cristhianzl Cristhianzl merged commit a018436 into main Nov 5, 2024
19 of 20 checks passed
@Cristhianzl Cristhianzl deleted the cz/components-sweep branch November 5, 2024 21:50
joaoguilhermeS pushed a commit that referenced this pull request Nov 7, 2024
📝 (NodeName/index.tsx): Add beta prop to NodeName component for better handling of beta features
📝 (NodeStatus/index.tsx): Import Badge component and add beta badge for beta nodes
📝 (GenericNode/index.tsx): Import Badge component and add beta badge for beta nodes
📝 (nodeToolbarComponent/index.tsx): Add border styling to nodeToolbarComponent for better visual separation
📝 (index.css): Update accent-pink and accent-pink-foreground colors for better contrast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants