Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Contributing folder #4415

Merged
merged 26 commits into from
Nov 12, 2024
Merged

Docs: Contributing folder #4415

merged 26 commits into from
Nov 12, 2024

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Nov 5, 2024

The Contributing docs pages required a refresh.

  • Contributing GitHub issues - confirmed this has not changed, cleaned up
  • Telemetry - confirmed this has not changed, cleaned up
  • How to Contribute Code - has been updated to reflect using uv before the makefile, cleaned up. Added guidance on descriptive PR titles for better release notes.
    @ogabrielluiz Please double check me on the Poetry and NPM local run, I'm not sure if this is up-to-date or useful. Thank you.

@mendonk mendonk self-assigned this Nov 5, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 5, 2024
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4415 will degrade performances by 16.78%

Comparing docs-telemetry-and-contributing (70d8e35) with main (01de9ef)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main docs-telemetry-and-contributing Change
test_load_flows 1,188.5 µs 982.9 µs +20.92%
test_successful_run_with_output_type_debug 375.6 ms 451.4 ms -16.78%

docs/docs/Contributing/contributing-how-to-contribute.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-how-to-contribute.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-how-to-contribute.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-github-issues.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-github-issues.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-github-issues.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-github-issues.md Outdated Show resolved Hide resolved
docs/docs/Contributing/contributing-github-issues.md Outdated Show resolved Hide resolved
@mendonk mendonk enabled auto-merge (squash) November 12, 2024 16:01
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@mendonk mendonk merged commit bcd7617 into main Nov 12, 2024
8 checks passed
@mendonk mendonk deleted the docs-telemetry-and-contributing branch November 12, 2024 17:05
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* issues

* contributing

* telemetry-cleanup

* name

* name

* pr-guidance

* Apply suggestions from code review

Co-authored-by: KimberlyFields <[email protected]>

* code-review

* move-discussions

* have-written

* why-to-run-locally

* clarify-how-to-contribute

* add-custom-component-page

* Apply suggestions from code review

Co-authored-by: KimberlyFields <[email protected]>

* update-join-the-community-age

---------

Co-authored-by: KimberlyFields <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants