-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve notes functionality, update theme colors definition and resolve ui and ux small bugs #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
javascript
Pull requests that update Javascript code
labels
Nov 5, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Nov 5, 2024
anovazzi1
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
joaoguilhermeS
pushed a commit
that referenced
this pull request
Nov 7, 2024
…resolve ui and ux small bugs (#4414) * Fixed background blur overlay color on dialogs * Try to fix f5 error * Fix text color of notes * Fix bg color of nodenode to first one available if not existent * Removed unused imports * Added new node colors * Updated color of placeholder note node * Fixed notes to appear as soon as when the add button is clicked * Added transparent option to notes * Fixed editor design * Fix design of notes editor * Update text color on the note node description * Added canvas dot variable * Added size and gap definition to background dots * Updated emerald colors and badge * used correct badges on tableAutoCellRender * Used correct colors on the component global variable badge * Fix color on light mode * Fixed emerald color on the status of component * Applied static pink to active icons on navs * Make sidebar narrower * Updated size of / * Fixed Beta and Legacy badges * Fixed position of chevron * Fixed node name input * Updated clear search button * Updated color for grid dots * Updated sidebar filter color * Added chat input check * Fixed sorting of flow sidebar component * Fix canvas color * Updated sticky notes test * Fixed tests * Fixed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates to the frontend components, focusing on enhancing the styling and functionality of nodes and their descriptions. The changes also include some code cleanups and improvements to the user interface elements.
Enhancements to Node Descriptions and Styling:
src/frontend/src/CustomNodes/GenericNode/components/NodeDescription/index.tsx
: AddedplaceholderClassName
prop, updated class names for better styling, and adjusted padding and width for elements. [1] [2] [3] [4] [5] [6]src/frontend/src/CustomNodes/GenericNode/components/NodeName/index.tsx
: ReplacedInputComponent
withInput
and updated theonChange
handler. [1] [2] [3]src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx
: Updated class names for status display to use new color scheme.src/frontend/src/CustomNodes/NoteNode/NoteToolbarComponent/index.tsx
: Improved background color handling and added conditional styling for color options. [1] [2] [3] [4]src/frontend/src/CustomNodes/NoteNode/index.tsx
: Enhanced background color selection logic and updated styles for the node description. [1] [2] [3]Code Cleanups and Refactoring:
src/frontend/src/CustomNodes/GenericNode/components/handleRenderComponent/index.tsx
: Removed unused imports and updated default values for color handling. [1] [2] [3]src/frontend/src/CustomNodes/GenericNode/index.tsx
: Removed unused import and updated the markdown class name for node description. [1] [2]src/frontend/src/components/inputComponent/components/popover/index.tsx
: Simplified imports and adjusted badge variant handling. [1] [2]src/frontend/src/components/tableComponent/components/tableAutoCellRender/index.tsx
: Updated badge variants for status display.src/frontend/src/components/ui/badge.tsx
: Added new badge variants and updated existing ones for better consistency.Other UI Improvements:
src/frontend/src/components/ui/dialog-with-no-close.tsx
: Adjusted overlay background color for better visibility.src/frontend/index.html
: Added<base href="/">
to the head for better relative URL handling.