Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle BYO Embeddings (#4387) #4410

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: Handle BYO Embeddings (#4387) #4410

merged 2 commits into from
Nov 5, 2024

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Nov 5, 2024

This PR fixes #4387 by passing in the optional embedding provider key properly

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 5, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 5, 2024
@erichare erichare enabled auto-merge (squash) November 5, 2024 19:00
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4410 will degrade performances by 16.78%

Comparing bugfix-astradb-byoe (397d197) with main (01de9ef)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bugfix-astradb-byoe Change
test_load_flows 1,188.5 µs 875.1 µs +35.82%
test_invalid_run_with_input_type_chat 14.9 ms 16.7 ms -10.39%
test_successful_run_with_input_type_any 452.3 ms 528.5 ms -14.41%
test_successful_run_with_output_type_debug 375.6 ms 451.4 ms -16.78%

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@erichare erichare merged commit 9d4d41c into main Nov 5, 2024
36 of 37 checks passed
@erichare erichare deleted the bugfix-astradb-byoe branch November 5, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Astra DB Vectorize doesn't allow for Bring-Your-Own-Embedding (BYOE)
2 participants