Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: center add and remove icon on button when is a inputList #4407

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request includes a small change to the InputListComponent in the inputListComponent directory. The change modifies the Button component's class names and adds a size property to improve styling and alignment.

@Cristhianzl Cristhianzl self-assigned this Nov 5, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 5, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 5, 2024
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4407 will degrade performances by 14.65%

Comparing cz/fix-icon-list (e5b1e2d) with main (7cc497a)

Summary

❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/fix-icon-list Change
test_successful_run_with_input_type_chat 450.8 ms 528.2 ms -14.65%

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 5, 2024 17:16
@Cristhianzl Cristhianzl merged commit d261077 into main Nov 5, 2024
19 of 20 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-icon-list branch November 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants