Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Properly log and set metric to none by default in Astra DB Component #4390

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Nov 4, 2024

This PR addresses some small issues in the Astra DB component related to logging and default value for Metric

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 4, 2024
@erichare erichare requested a review from Cristhianzl November 4, 2024 21:53
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@erichare erichare enabled auto-merge (squash) November 4, 2024 22:02
@erichare erichare merged commit b6e8d41 into main Nov 5, 2024
27 of 28 checks passed
@erichare erichare deleted the bugfix-astradb-comp-updates branch November 5, 2024 01:41
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…mponent (langflow-ai#4390)

* bugfix: Properly log and set metric to none by default

* Update Vector Store RAG.json

* Update astradb.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants