-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Optimize Setting of Output Required Inputs #4389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix required inputs not updated if its already defined
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Nov 4, 2024
edwinjosechittilappilly
requested review from
ogabrielluiz,
italojohnny,
Cristhianzl and
jordanrfrazier
November 4, 2024 21:13
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Nov 4, 2024
ogabrielluiz
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix required inputs not updated if its already defined
ogabrielluiz
force-pushed
the
fix-agent-as-tools
branch
from
November 5, 2024 01:10
524b4a1
to
3f97e2b
Compare
…angflow into fix-agent-as-tools
CodSpeed Performance ReportMerging #4389 will improve performances by 60.32%Comparing Summary
Benchmarks breakdown
|
Added pytest : Splitter single test to multiple components. Explicitly added outputs to open ai component.
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Nov 5, 2024
ogabrielluiz
added a commit
that referenced
this pull request
Nov 5, 2024
This reverts commit 7cc497a.
ogabrielluiz
added a commit
that referenced
this pull request
Nov 5, 2024
This reverts commit 7cc497a.
ogabrielluiz
added a commit
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This update modifies the logic for setting required inputs for outputs in the
Component
class. Previously, the code would set required inputs even if they were already defined. With this change, the required inputs are only set if they are not already specified. This ensures that existing configurations are preserved and only missing required inputs are added.Changes Made:
Rationale:
This change improves the efficiency of the component setup process by avoiding redundant operations. It ensures that the required inputs are only set when necessary, which can help prevent potential overwrites of existing configurations.
Impact:
This change should not affect existing functionality but will optimize the setup process for components with pre-defined required inputs.
AutoGenerated
This pull request includes a small change to the
_set_output_return_type
method in thesrc/backend/base/langflow/custom/custom_component/component.py
file. The change adds a condition to continue the loop if theoutput
hasrequired_inputs
.src/backend/base/langflow/custom/custom_component/component.py
: Added a condition to skip outputs withrequired_inputs
in the_set_output_return_type
method.