Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minimize and expand functionality for UI nodes #4388

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request introduces a new feature that allows users to minimize and expand nodes in the UI. It includes changes to the frontend components, styles, and tests to support this functionality. The most important changes include updates to the GenericNode and HandleRenderComponent components, as well as new styles and tests.

Feature Implementation

Style Adjustments

Testing

… on showNode state

🔧 (frontend): update node internals when toggling showNode state
📝 (frontend): add test for minimizing and expanding components
@Cristhianzl Cristhianzl self-assigned this Nov 4, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 4, 2024
@dosubot dosubot bot added enhancement New feature or request javascript Pull requests that update Javascript code labels Nov 4, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Nov 4, 2024
…on to improve code readability and maintainability

🔧 (handleRenderComponent/index.tsx): refactor handleClick function to improve code readability and maintainability
@Cristhianzl Cristhianzl changed the title fix: add the new minimize UI feat: add the new minimize UI Nov 4, 2024
@Cristhianzl Cristhianzl changed the title feat: add the new minimize UI feat: add minimize and expand functionality for UI nodes Nov 4, 2024
@github-actions github-actions bot added enhancement New feature or request and removed bug Something isn't working enhancement New feature or request labels Nov 4, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4388 will degrade performances by 22.56%

Comparing cz/minimize (81a2ef7) with main (7cc497a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/minimize Change
test_load_flows 874.9 µs 1,129.8 µs -22.56%
test_successful_run_with_output_type_debug 527.4 ms 451.6 ms +16.78%

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 5, 2024 12:53
@ogabrielluiz ogabrielluiz merged commit 84d07d9 into main Nov 5, 2024
30 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/minimize branch November 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants