-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add minimize and expand functionality for UI nodes #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on showNode state 🔧 (frontend): update node internals when toggling showNode state 📝 (frontend): add test for minimizing and expanding components
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Nov 4, 2024
dosubot
bot
added
enhancement
New feature or request
javascript
Pull requests that update Javascript code
labels
Nov 4, 2024
github-actions
bot
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Nov 4, 2024
…on to improve code readability and maintainability 🔧 (handleRenderComponent/index.tsx): refactor handleClick function to improve code readability and maintainability
Cristhianzl
changed the title
fix: add the new minimize UI
feat: add the new minimize UI
Nov 4, 2024
Cristhianzl
changed the title
feat: add the new minimize UI
feat: add minimize and expand functionality for UI nodes
Nov 4, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
bug
Something isn't working
enhancement
New feature or request
labels
Nov 4, 2024
anovazzi1
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CodSpeed Performance ReportMerging #4388 will degrade performances by 22.56%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that allows users to minimize and expand nodes in the UI. It includes changes to the frontend components, styles, and tests to support this functionality. The most important changes include updates to the
GenericNode
andHandleRenderComponent
components, as well as new styles and tests.Feature Implementation
src/frontend/src/CustomNodes/GenericNode/index.tsx
: Updated theGenericNode
component to conditionally render different styles and elements based on theshowNode
state. [1] [2] [3] [4] [5]src/frontend/src/CustomNodes/GenericNode/components/NodeName/index.tsx
: Modified theNodeName
component to handle double-click events and adjust styles based on theshowNode
state.src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx
: Adjusted theNodeOutputField
component to render theHandle
whenshowNode
is false.src/frontend/src/CustomNodes/GenericNode/components/handleRenderComponent/index.tsx
: Updated theHandleRenderComponent
to measure node dimensions and adjust styles based on theshowNode
state. [1] [2] [3] [4]src/frontend/src/CustomNodes/GenericNode/components/nodeIcon/index.tsx
: Modified theNodeIcon
component to adjust styles based on theshowNode
state.Style Adjustments
src/frontend/src/style/applies.css
: Updated styles for various classes to support the new minimize and expand functionality. [1] [2] [3]src/frontend/src/style/classes.css
: Added new styles for handle elements whenshowNode
is false.Testing
src/frontend/tests/extended/features/minimize.spec.ts
: Added a new test to verify that users can minimize and expand a component.