Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add decision flow test #4384

Merged
merged 14 commits into from
Nov 5, 2024
Merged

tests: add decision flow test #4384

merged 14 commits into from
Nov 5, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request includes changes to the src/frontend/tests/core/integrations/Vector Store.spec.ts file, primarily focused on cleaning up and re-enabling previously commented-out test code. The most important changes include re-enabling the test setup and execution steps, ensuring the necessary environment variables are checked, and restoring the test logic for the "Vector Store RAG" feature.

Test setup and execution:

  • Re-enabled the checks for necessary environment variables (OPENAI_API_KEY, ASTRA_DB_API_ENDPOINT, ASTRA_DB_APPLICATION_TOKEN).
  • Restored the navigation and interaction steps for the "Vector Store RAG" test, including waiting for selectors, handling modals, and interacting with UI elements.

Test logic restoration:

  • Re-implemented the logic to handle outdated components, API key inputs, and Astra DB configurations.
  • Restored the file upload and execution steps for running the "Vector Store RAG" test, including verifying the test file visibility and running the test commands.
  • Re-enabled the steps to interact with the chat playground, including filling inputs and verifying message logs.

… variables are not set and improve test flow for Vector Store RAG test.
…trol' for better clarity and consistency

📝 (decisionFlow.spec.ts): Refactor test case to skip if OPENAI_API_KEY is not provided and improve code readability and maintainability by restructuring and commenting out unnecessary code blocks
@Cristhianzl Cristhianzl added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@Cristhianzl Cristhianzl self-assigned this Nov 4, 2024
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 4, 2024
@Cristhianzl Cristhianzl added lgtm This PR has been approved by a maintainer and removed lgtm This PR has been approved by a maintainer labels Nov 4, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 5, 2024 01:41
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4384 will degrade performances by 32.89%

Comparing cz/fix_tests_ci (a994ca1) with main (7cc497a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/fix_tests_ci Change
test_load_flows 874.9 µs 1,303.6 µs -32.89%
test_successful_run_with_output_type_debug 527.4 ms 451.4 ms +16.85%

…anges in the frontend code and improve test reliability
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cristhianzl Cristhianzl merged commit 1443af2 into main Nov 5, 2024
29 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix_tests_ci branch November 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants