-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add decision flow test #4384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variables are not set and improve test flow for Vector Store RAG test.
…trol' for better clarity and consistency 📝 (decisionFlow.spec.ts): Refactor test case to skip if OPENAI_API_KEY is not provided and improve code readability and maintainability by restructuring and commenting out unnecessary code blocks
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Nov 4, 2024
…d unused code to improve code readability and maintainability.
Cristhianzl
added
lgtm
This PR has been approved by a maintainer
and removed
lgtm
This PR has been approved by a maintainer
labels
Nov 4, 2024
…or clicking elements and waiting for visibility to improve code readability and maintainability 🔧 (deleteFlows.spec.ts): Refactor test to use separate functions for waiting for and interacting with elements to improve code readability and maintainability
CodSpeed Performance ReportMerging #4384 will degrade performances by 32.89%Comparing Summary
Benchmarks breakdown
|
…anges in the frontend code and improve test reliability
anovazzi1
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/frontend/tests/core/integrations/Vector Store.spec.ts
file, primarily focused on cleaning up and re-enabling previously commented-out test code. The most important changes include re-enabling the test setup and execution steps, ensuring the necessary environment variables are checked, and restoring the test logic for the "Vector Store RAG" feature.Test setup and execution:
OPENAI_API_KEY
,ASTRA_DB_API_ENDPOINT
,ASTRA_DB_APPLICATION_TOKEN
).Test logic restoration: