Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar animations, colors and minor design fixes #4379

Merged
merged 35 commits into from
Nov 5, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes significant updates to the sidebar component and minor changes to the badge component and AWS icon. The most important changes include the removal of mobile-specific sidebar logic, the addition of a width prop to the sidebar, and the adjustment of styles for various sidebar elements.

Sidebar Component Updates:

  • Removed mobile-specific logic and state from the sidebar, simplifying the component and reducing complexity. (src/frontend/src/components/ui/sidebar.tsx) [1] [2] [3] [4] [5] [6] [7] [8]
  • Added a width prop to the SidebarProvider to allow dynamic width setting for the sidebar. (src/frontend/src/components/ui/sidebar.tsx) [1] [2]
  • Adjusted styles for various sidebar elements to improve responsiveness and visual consistency. (src/frontend/src/components/ui/sidebar.tsx) [1] [2] [3] [4] [5] [6] [7] [8] [9]

Badge Component Update:

  • Added border-0 to secondaryStatic and pinkStatic variants to remove the border. (src/frontend/src/components/ui/badge.tsx)

AWS Icon Update:

  • Modified the AWS icon to change the fill color based on the dark mode state. (src/frontend/src/icons/AWS/AWS.jsx, src/frontend/src/icons/AWS/index.tsx) [1] [2]

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Nov 4, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) November 4, 2024 18:21
@lucaseduoli lucaseduoli merged commit 91b650f into main Nov 5, 2024
27 of 28 checks passed
@lucaseduoli lucaseduoli deleted the fix/sidebar_sweep branch November 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants