fix: stop taking zoom into account in tooltip render #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion and simplify tooltip positioning logic to improve code readability and maintainability.
dosubot
bot
added
the
size:L
dosubot
bot
added
bug
github-actions
bot
added
bug
ogabrielluiz
changed the title
github-actions
bot
added
bug
…mes for elements to be visible ⬆️ (userSettings.spec.ts): update tests to include explicit wait times for elements to be visible
…es by clicking on checkbox and deleting an item to ensure proper functionality
…or clicking elements and waiting for visibility to improve code readability and maintainability 🔧 (deleteFlows.spec.ts): Refactor test to use separate functions for waiting for and interacting with elements to improve code readability and maintainability
…g by tag in tests to match the actual text displayed on the page
…m running due to missing STORE_API_KEY environment variable
… prevent it from running due to missing STORE_API_KEY environment variable
…ronment variable to run, as it is not available in the test environment
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* 🔧 (handleRenderComponent/index.tsx): Remove unused getTranslateX function and simplify tooltip positioning logic to improve code readability and maintainability. * ⬆️ (auto-login-off.spec.ts): update tests to include explicit wait times for elements to be visible ⬆️ (userSettings.spec.ts): update tests to include explicit wait times for elements to be visible * ✅ (userSettings.spec.ts): update test to interact with global variables by clicking on checkbox and deleting an item to ensure proper functionality * ✨ (store-shard-2.spec.ts): Refactor test to use a reusable function for clicking elements and waiting for visibility to improve code readability and maintainability 🔧 (deleteFlows.spec.ts): Refactor test to use separate functions for waiting for and interacting with elements to improve code readability and maintainability * 🐛 (store-shard-2.spec.ts): fix incorrect text comparison for filtering by tag in tests to match the actual text displayed on the page * ✅ (store-shard-2.spec.ts): mark the test as skipped to prevent it from running due to missing STORE_API_KEY environment variable * ✅ (deleteFlows.spec.ts): skip the test case "should delete a flow" to prevent it from running due to missing STORE_API_KEY environment variable * ✅ (store-shard-3.spec.ts): skip tests that require STORE_API_KEY environment variable to run, as it is not available in the test environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
HandleRenderComponentin thesrc/frontend/src/CustomNodes/GenericNode/components/handleRenderComponent/index.tsxfile. The main focus of these changes is to simplify the component structure and remove unnecessary code.Simplification of component structure:
getTranslateXfunction and its associated logic for determining translation classes based on thezoomlevel.ShadTooltipcomponent to wrap theHandlecomponent directly, eliminating redundantdivelements. [1] [2] [3]