ref: Make some functions that don't await non-async (RUF029) #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
ogabrielluiz
requested changes
Nov 3, 2024
cbornet
commented
Nov 4, 2024
| @@ -82,7 +83,7 @@ async def get_current_user( | |||
| ) -> User: | |||
| if token: | |||
| return await get_current_user_by_jwt(token, db) | |||
| user = await api_key_security(query_param, header_param, db) | |||
| user = await asyncio.to_thread(api_key_security, query_param, header_param, db) | |||
There was a problem hiding this comment.
Actually this is incorrect...
The db Session is not-thread-safe
ogabrielluiz
pushed a commit
that referenced
this pull request
Nov 4, 2024
Make some functions that don't await non-async (RUF029)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some functions that don't await non-async (RUF029)