Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove some get_event_loop calls #4366

Merged
merged 1 commit into from
Nov 2, 2024
Merged

ref: Remove some get_event_loop calls #4366

merged 1 commit into from
Nov 2, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 2, 2024 •
edited
Loading

get_file_paths doesn't do any await so it can be made a sync function.
In turn get_file_content_dicts and from_template_and_variables can be made sync too.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 2, 2024
ogabrielluiz
ogabrielluiz approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cbornet

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 2, 2024
@cbornet cbornet merged commit 35e2487 into langflow-ai:main Nov 2, 2024
27 of 28 checks passed
@cbornet cbornet deleted the remove-get-event-loop branch November 2, 2024 22:04
ogabrielluiz pushed a commit that referenced this pull request Nov 4, 2024
@cbornet @ogabrielluiz
ref: Remove some get_event_loop calls (#4366)
f09f879 
Remove some get_event_loop calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz