Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix folder selection, login screen layout, drag-and-drop, and icon issues #4362

Merged
merged 13 commits into from
Nov 5, 2024
Merged

fix: Fix folder selection, login screen layout, drag-and-drop, and icon issues #4362

merged 13 commits into from
Nov 5, 2024

Conversation

deon-sanchez
Copy link
Collaborator

@deon-sanchez deon-sanchez commented Nov 1, 2024 •
edited by mfortman11
Loading

Fixes:

  • Users can no longer select mutliple folders at once
  • Login screen no properly fills the page
  • Drag and drop behavior has been restored
  • Missing icon for Export/Import added
  • Folder name mismatch for download after renaming fixed
  • Documentation link fixed

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 1, 2024
@mfortman11 mfortman11 changed the title Lfen 236 fix: Fix Home Page Issues post Uplift Nov 4, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2024
@lucaseduoli lucaseduoli self-requested a review November 5, 2024 20:52
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4362 will degrade performances by 29.07%

Comparing lfen-236 (34df484) with main (01de9ef)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main lfen-236 Change
⚡ test_load_flows 1.2 ms 1 ms +18.08%
❌ test_invalid_run_with_input_type_chat 14.9 ms 20.3 ms -26.24%
❌ test_successful_run_with_output_type_debug 375.6 ms 529.6 ms -29.07%

anovazzi1
anovazzi1 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@mfortman11 mfortman11 enabled auto-merge (squash) November 5, 2024 22:32
@mfortman11 mfortman11 merged commit f17934b into main Nov 5, 2024
20 of 21 checks passed
@mfortman11 mfortman11 deleted the lfen-236 branch November 5, 2024 22:47
@ogabrielluiz ogabrielluiz changed the title fix: Fix Home Page Issues post Uplift fix: Fix folder selection, login screen layout, drag-and-drop, and icon issues Nov 5, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 5, 2024
joaoguilhermeS pushed a commit that referenced this pull request Nov 7, 2024
@deon-sanchez @mfortman11
@autofix-ci @joaoguilhermeS
fix: Fix Home Page Issues post Uplift (#4362)
ac6320a 
* fixes spotted by otavio

* Refactor folder export logic and fix folder name in download link

* Refactor getTemplateStyle to handle partial matches in flowData.name

* Refactor folder export logic and add file drop functionality

* spelling

* Re enable/fix drag and drop behaviors

* [autofix.ci] apply automated fixes

* folder upload fix

---------

Co-authored-by: Mike Fortman <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

@lucaseduoli lucaseduoli Awaiting requested review from lucaseduoli

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deon-sanchez @anovazzi1 @mfortman11