Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update GCP Deployment #4358

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Docs: Update GCP Deployment #4358

merged 1 commit into from
Nov 2, 2024

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Nov 1, 2024

  1. Fix broken inline image.
  2. Make the task clearer to the user.
  3. Tested and works.

@mendonk mendonk self-assigned this Nov 1, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 1, 2024
ogabrielluiz
ogabrielluiz approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back, @mendonk

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 1, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 2, 2024 16:16
@ogabrielluiz ogabrielluiz merged commit 9de3724 into main Nov 2, 2024
9 of 10 checks passed
@ogabrielluiz ogabrielluiz deleted the docs-gcp-deployment branch November 2, 2024 16:18
ogabrielluiz pushed a commit that referenced this pull request Nov 4, 2024
@mendonk @ogabrielluiz
Docs: Update GCP Deployment (#4358)
72358c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@edwinjosechittilappilly edwinjosechittilappilly Awaiting requested review from edwinjosechittilappilly

Assignees

@mendonk mendonk

Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendonk @ogabrielluiz