Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update api configuration #4354

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Docs: update api configuration #4354

merged 2 commits into from
Nov 2, 2024

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Nov 1, 2024

  1. Fix code samples.
  2. Add example for passing API key as a command line arg to python script.
  3. Clean up language and organization.

These examples return the expected output, but I can't tell if the API key is doing anything. I still have questions on how this API key is actually being used.

@mendonk mendonk self-assigned this Nov 1, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 1, 2024
edwinjosechittilappilly
edwinjosechittilappilly approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 2, 2024
ogabrielluiz
ogabrielluiz approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 2, 2024 13:17
@ogabrielluiz ogabrielluiz merged commit dc4e0e5 into main Nov 2, 2024
9 of 10 checks passed
@ogabrielluiz ogabrielluiz deleted the docs-update-api-configuration branch November 2, 2024 13:18
ogabrielluiz pushed a commit that referenced this pull request Nov 4, 2024
@mendonk @ogabrielluiz
Docs: update api configuration (#4354)
4694540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@edwinjosechittilappilly edwinjosechittilappilly edwinjosechittilappilly approved these changes

Assignees

@mendonk mendonk

Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mendonk @edwinjosechittilappilly @ogabrielluiz