Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changes the ui and ux of the api dialog to improve usability #4338

Merged
merged 29 commits into from
Nov 5, 2024
Merged

feat: changes the ui and ux of the api dialog to improve usability #4338

merged 29 commits into from
Nov 5, 2024

Conversation

mfortman11
Copy link
Collaborator

@mfortman11 mfortman11 commented Oct 31, 2024 •
edited
Loading

Screenshot 2024-11-04 at 1 19 56 PM

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Oct 31, 2024
@mfortman11 mfortman11 added the lgtm This PR has been approved by a maintainer label Oct 31, 2024
ogabrielluiz
ogabrielluiz previously requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mfortman11

Thanks for this. It looks really good.

Don't forget to provide a better PR title

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@mfortman11 mfortman11 changed the title feat: Api dialog redesign/uplift feat: Redesign the API dialog for the visual uplift Nov 4, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 4, 2024
@github-actions github-actions bot removed the enhancement New feature or request label Nov 4, 2024
@github-actions github-actions bot added the enhancement New feature or request label Nov 4, 2024
mfortman11
mfortman11 commented Nov 4, 2024
View reviewed changes
src/frontend/src/components/codeTabsComponent/ChatCodeTabComponent.tsx
@@ -49,7 +49,7 @@ export default function SimplifiedCodeTabComponent({
</div>
<SyntaxHighlighter
language={language.toLowerCase()}
style={oneDark}
style={tomorrow}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes syntax highlighter theme to match throughout

mfortman11
mfortman11 commented Nov 4, 2024
View reviewed changes
src/frontend/src/components/ui/dialog.tsx
@@ -26,7 +26,7 @@ const DialogOverlay = React.forwardRef<
<DialogPrimitive.Overlay
ref={ref}
className={cn(
"nopan nodelete nodrag noflow fixed inset-0 bottom-0 left-0 right-0 top-0 z-50 overflow-auto bg-blur-shared backdrop-blur-sm data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0",
"nopan nodelete nodrag noflow fixed inset-0 bottom-0 left-0 right-0 top-0 z-40 overflow-auto bg-blur-shared backdrop-blur-sm data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduces z index for dialogs so tooltips can be shown in dialogs as well

mfortman11 and others added 9 commits November 4, 2024 13:30
@mfortman11
Merge branch 'main' of github.com:langflow-ai/langflow into api-dialo…
dad0c78 
…g-uplift
@mfortman11
Merge branch 'api-dialog-uplift' of github.com:mfortman11/langflow in…
15b9bb2 
…to api-dialog-uplift
@mfortman11
Merge branch 'main' into api-dialog-uplift
25c4323
@mfortman11
Merge branch 'main' of github.com:langflow-ai/langflow into api-dialo…
da4b8c3 
…g-uplift
@mfortman11
dark vs light style + merge fix
569b007
@mfortman11
Merge branch 'api-dialog-uplift' of github.com:mfortman11/langflow in…
e46ebf9 
…to api-dialog-uplift
@autofix-ci
[autofix.ci] apply automated fixes
da1c2fe
@mfortman11
Merge branch 'main' of github.com:langflow-ai/langflow into api-dialo…
58e453b 
…g-uplift
@mfortman11
Merge branch 'api-dialog-uplift' of github.com:mfortman11/langflow in…
f89c39f 
…to api-dialog-uplift
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4338 will improve performances by 35.92%

Comparing mfortman11:api-dialog-uplift (da1c2fe) with main (b6e8d41)

Summary

⚡ 3 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main mfortman11:api-dialog-uplift Change
⚡ test_load_flows 1.4 ms 1 ms +35.92%
⚡ test_invalid_run_with_input_type_chat 17.7 ms 14.1 ms +25.85%
⚡ test_successful_run_with_input_type_text 528.3 ms 452.4 ms +16.79%

lucaseduoli
lucaseduoli approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@lucaseduoli lucaseduoli changed the title feat: Redesign the API dialog for the visual uplift feat: ui and ux changes to the api dialog to improve usability Nov 5, 2024
@lucaseduoli lucaseduoli changed the title feat: ui and ux changes to the api dialog to improve usability feat: changes the ui and ux of the api dialog to improve usability Nov 5, 2024
@ogabrielluiz ogabrielluiz self-requested a review November 5, 2024 16:20
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 5, 2024
@mfortman11 mfortman11 enabled auto-merge (squash) November 5, 2024 16:26
@mfortman11 mfortman11 merged commit f6616f5 into langflow-ai:main Nov 5, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaseduoli lucaseduoli lucaseduoli approved these changes

@anovazzi1 anovazzi1 Awaiting requested review from anovazzi1

@Cristhianzl Cristhianzl Awaiting requested review from Cristhianzl

@ogabrielluiz ogabrielluiz Awaiting requested review from ogabrielluiz

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfortman11 @ogabrielluiz @lucaseduoli