feat: add dynamic outputs to Component #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
ogabrielluiz
force-pushed
the
feat-add-dynamic-output-and-tool-output-
branch
from
fe3154a
to
7b342f4
Compare
dosubot
bot
added
the
size:L
github-actions
bot
added
enhancement
ogabrielluiz
requested review from
jordanrfrazier and
edwinjosechittilappilly
ogabrielluiz
force-pushed
the
feat-add-dynamic-output-and-tool-output-
branch
from
fe09438
to
ac759a2
Compare
This commit refactors the Component class in the `component.py` file. It introduces two new methods: `update_inputs` and `run_and_validate_update_outputs`. The `update_inputs` method allows for updating the build configuration with new field values, while the `run_and_validate_update_outputs` method updates the frontend node and validates the outputs. Additionally, the `_validate_frontend_node` method is added to check if all outputs are valid. The `_set_output_types` method is modified to accept a list of outputs and set their return types. Overall, these changes improve the functionality and maintainability of the Component class.
ogabrielluiz
force-pushed
the
feat-add-dynamic-output-and-tool-output-
branch
from
ac759a2
to
ab42efb
Compare
|
Earlier frontend_node was used to update the inputs and later we moved to build_config. In the same way, should we utilize build_config instead of frontend_node so the DX would be much better? |
They serve different purposes. We could put them in a single method but I think that would make it confusing |
edwinjosechittilappilly
approved these changes
Nov 1, 2024
…dant test_get_sidebar_components
ogabrielluiz
added a commit
that referenced
this pull request
Nov 4, 2024
* Refine condition to check for undefined value in use-handle-new-value hook * update mutateTemplate to use APIClassType * Refactor Component class to update inputs and validate outputs This commit refactors the Component class in the `component.py` file. It introduces two new methods: `update_inputs` and `run_and_validate_update_outputs`. The `update_inputs` method allows for updating the build configuration with new field values, while the `run_and_validate_update_outputs` method updates the frontend node and validates the outputs. Additionally, the `_validate_frontend_node` method is added to check if all outputs are valid. The `_set_output_types` method is modified to accept a list of outputs and set their return types. Overall, these changes improve the functionality and maintainability of the Component class. * Add dynamic output validation in API endpoint for component updates * Update build_config to store field_value under "value" key * Refactor: Convert dict values to list in _set_output_types call * Add type check for `cc_instance` before calling `run_and_validate_update_outputs` * Add DynamicOutputComponent with configurable outputs based on input * Add test for updating component outputs with dynamic code input * Refactor: Make get_dynamic_output_component_code asynchronous for improved performance --------- Co-authored-by: Edwin Jose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the backend and frontend functionality of the Langflow project. The most important changes include updates to the custom component handling, validation improvements, and modifications to the frontend data fetching and mutation logic.
Backend Improvements:
src/backend/base/langflow/api/v1/endpoints.py: Refactored imports to a single line for better readability and added logic to update component templates and validate outputs during custom component updates. [1] [2]src/backend/base/langflow/custom/custom_component/component.py: Added validation for frontend node outputs and new methods for updating inputs and outputs. [1] [2] [3] [4]src/backend/tests/data/dynamic_output_component.py: Introduced a newDynamicOutputComponentclass to serve as a template for creating custom components.src/backend/tests/unit/api/v1/test_endpoints.py: Added a test case for updating component outputs to ensure the new functionality works as expected. [1] [2]Frontend Improvements:
src/frontend/src/CustomNodes/helpers/mutate-template.ts: Updated themutateTemplatefunction to handle new template and output structures. [1] [2] [3]src/frontend/src/CustomNodes/hooks/use-fetch-data-on-mount.tsx: Modified import statements and updated the type forpostTemplateValuetoAPIClassType. [1] [2]src/frontend/src/CustomNodes/hooks/use-handle-new-value.tsx: Changed the condition to check forundefinedvalues in theuseHandleOnNewValuehook.src/frontend/src/controllers/API/queries/nodes/use-post-template-value.ts: Updated the mutation function to returnAPIClassTypeinstead ofAPITemplateTypeand adjusted the response handling accordingly. [1] [2] [3]