fix: Make logger file sink non-blocking when used with asyncio #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
ogabrielluiz
approved these changes
Oct 28, 2024
cbornet
commented
Oct 28, 2024
| path=file, | ||
| rotation="10 MB", # Log rotation based on file size | ||
| ) | ||
| super().__init__(self.write_async, None, ErrorInterceptor(_defaults.LOGURU_CATCH, -1)) |
There was a problem hiding this comment.
Unfortunately, we can't get the handle id here. But I don't think this is a big problem.
There was a problem hiding this comment.
I agree, unless we can define it in the logger.configure( call
github-actions
bot
added
bug
ogabrielluiz
force-pushed
the
async-log-file
branch
from
20bf358
to
ef996e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Loguru FileSink is blocking so it is bad to use it in the event loop.
Use instead an AsyncSink wrapping the FileSink to delegate the log writing to the default thread pool.
NB: when the AsyncFileSink is used, logs produced outside of the event loop are not written to the file.