Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix issues with use of async #4296

Merged
merged 3 commits into from
Oct 27, 2024
Merged

fix: Fix issues with use of async #4296

merged 3 commits into from
Oct 27, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 27, 2024 •
edited
Loading

Fix issues with use of async

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 27, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 27, 2024
cbornet
cbornet commented Oct 27, 2024
View reviewed changes
src/backend/base/langflow/custom/custom_component/component.py
result = await result
result = await method()
else:
result = await asyncio.to_thread(method)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output.method could block

ogabrielluiz
ogabrielluiz requested changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part from the comment, LGTM

@ogabrielluiz ogabrielluiz added the lgtm This PR has been approved by a maintainer label Oct 27, 2024
ogabrielluiz
ogabrielluiz approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz merged commit d567b85 into langflow-ai:main Oct 27, 2024
27 checks passed
@cbornet cbornet deleted the async-fix branch October 28, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz