feat: Raise exception in tests when blocking code is called in event loop #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
cbornet
force-pushed
the
detect-blocking
branch
from
a3487cf
to
1449e96
Compare
cbornet
commented
Oct 26, 2024
cbornet
force-pushed
the
detect-blocking
branch
from
1449e96
to
7837c19
Compare
cbornet
commented
Oct 26, 2024
| @@ -93,15 +94,16 @@ async def _queue_event(self, payload) -> None: | |||
| async def log_package_version(self) -> None: | |||
| python_version = ".".join(platform.python_version().split(".")[:2]) | |||
| version_info = get_version_info() | |||
| architecture = platform.architecture()[0] | |||
There was a problem hiding this comment.
Detected by the block buster 😀
cbornet
force-pushed
the
detect-blocking
branch
4 times, most recently
from
6773382
to
3145ff7
Compare
dosubot
bot
added
size:L
cbornet
force-pushed
the
detect-blocking
branch
from
3145ff7
to
897cb8c
Compare
github-actions
bot
added
enhancement
ogabrielluiz
approved these changes
Nov 2, 2024
cbornet
force-pushed
the
detect-blocking
branch
4 times, most recently
from
c6ca95b
to
1ce2a6b
Compare
cbornet
force-pushed
the
detect-blocking
branch
from
1ce2a6b
to
9d0ec6b
Compare
ogabrielluiz
pushed a commit
that referenced
this pull request
Nov 4, 2024
…loop (#4293) Raise exception in tests when blocking code is called in event loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise exception in tests when blocking code is called in event loop