Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with adding global variable when input is connected #4289

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request fixes an issue where a global variable could be added when the input was connected. The changes ensure that the global variable is not added in this scenario.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Oct 25, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 25, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 7, 2024 11:35
@ogabrielluiz ogabrielluiz merged commit 472b5fb into main Nov 7, 2024
20 of 21 checks passed
@ogabrielluiz ogabrielluiz deleted the fixGlobalVariables branch November 7, 2024 11:47
joaoguilhermeS pushed a commit that referenced this pull request Nov 7, 2024
#4289)

* fix: prevent add global variable when inpiut is connected

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants