Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance backend with context management, error handling, and refactored code #4286

Merged
merged 49 commits into from
Nov 8, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Oct 25, 2024

This pull request includes significant updates to the backend, focusing on enhancing context management, improving error handling, and refactoring code for better maintainability. The most important changes include the introduction of the AgentContext class, updates to the Component class for context handling, and various improvements to the graph and tracing services.

Check the added test for an example use case of the context.

Context Management Enhancements:

Error Handling Improvements:

Code Refactoring:

Graph Improvements:

Tracing Service Updates:

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Oct 25, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 25, 2024
@ogabrielluiz ogabrielluiz marked this pull request as draft October 25, 2024 14:52
@ogabrielluiz ogabrielluiz marked this pull request as ready for review October 25, 2024 17:13
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 25, 2024
@ogabrielluiz ogabrielluiz changed the title feat: Enhance backend with improved context management, error handling, and refactored code feat: Enhance backend with context management, error handling, and refactored code Oct 25, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 25, 2024
Copy link
Member

@italojohnny italojohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the unit tests three times, and they consistently failed at the same points.
Screenshot 2024-10-28 at 07 40 30

@ogabrielluiz ogabrielluiz force-pushed the feat-context branch 2 times, most recently from 1d49939 to 573afac Compare October 28, 2024 17:47
…and context management

- Introduced `AgentActionRouter` to route agent flow based on action type.
- Added `DecideActionComponent` for determining actions from context and prompts.
- Implemented `ExecuteActionComponent` to execute actions using available tools.
- Created `GenerateThoughtComponent` for generating thoughts based on context.
- Developed `ProvideFinalAnswerComponent` to generate final answers from context.
- Built `AgentContextBuilder` for constructing `AgentContext` instances.
- Added `ObserveResultComponent` to process and observe action results.
- Implemented `CheckTerminationComponent` to determine if the agent should continue or terminate.
…tion

- Introduced `AgentContext` class in `context.py` to handle agent state, including tools, language model, and context history.
- Implemented serialization methods for converting agent context to JSON-compatible format.
- Added validation for language model instances to ensure compatibility.
- Provided methods for updating and retrieving full context, including context history management.
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 5, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 5, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 7, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 8, 2024 13:33
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #4286 will degrade performances by 14.64%

Comparing feat-context (06d79bf) with main (c5495c4)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat-context Change
test_invalid_run_with_input_type_chat 14.5 ms 16.1 ms -10.16%
test_successful_run_with_input_type_any 451.2 ms 528.5 ms -14.64%
test_successful_run_with_input_type_text 450.9 ms 393.1 ms +14.7%
test_successful_run_with_output_type_debug 500.3 ms 451.3 ms +10.86%

@ogabrielluiz ogabrielluiz merged commit 8681c56 into main Nov 8, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the feat-context branch November 8, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants