Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix async usage in app startup #4285

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 25, 2024

Removes a lot of Task was destroyed but it is pending! warnings during tests

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 25, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 25, 2024
@cbornet cbornet force-pushed the async-startup branch 2 times, most recently from 7484ad6 to 64aeea2 Compare October 26, 2024 13:40
@cbornet cbornet enabled auto-merge (squash) October 27, 2024 14:53
@cbornet cbornet merged commit c8bdcf3 into langflow-ai:main Oct 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants