fix: make sure data is json serializable #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the `recursive_serialize_or_str` function from `schema.py` to a new `serialize.py` module for better modularity and reusability. - Updated imports in `data.py`, `artifact.py`, and `schema.py` to reflect the new location of the `recursive_serialize_or_str` function. - Enhanced the `recursive_serialize_or_str` function to handle `datetime` objects by converting them to ISO format.
dosubot
bot
added
size:M
github-actions
bot
added
bug
|
This looks good. Should we also update the DateTime objects in message.py ? The current update may not cause issues, but should the datetime in the message also be converted to ISO format? |
Tested this PR with the error that I had in PR #4258 (By merging both changes in a new branch) |
| return str(obj) | ||
| except Exception: # noqa: BLE001 | ||
| logger.debug(f"Cannot serialize object {obj}") | ||
| return str(obj) |
There was a problem hiding this comment.
Curious the downstream effects of this. Is this currently used for serializing an object for caching?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two commits. The first commit enhances the data serialization process by adding recursive handling in the
to_jsonmethod. This allows for better handling ofdatetimeobjects by converting them to ISO format. The second commit refactors therecursive_serialize_or_strfunction into a separate module calledserialize.py. This improves modularity and reusability of the code. The function is moved fromschema.pyto the new module, and the imports indata.py,artifact.py, andschema.pyare updated accordingly.