-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Semantic Text Splitter Component (Text Splitters) #4254
Conversation
5e5b9dd
to
1c6db48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaoguilhermeS is langchain_experimental a part of the pyproject of langflow? if not @ogabrielluiz can we add it to the pyproject?
@joaoguilhermeS Can you confirm if it's already added by uv to the pyproject file?
Also, I suggest we add the beta as True in the component since it is a part of langchain_experimental
1c6db48
to
dbc8887
Compare
Thanks for your review @edwinjosechittilappilly I have added the langchain_experimental to the pyproject and everything seems to be working. I also added the beta flag on the Semantic Text Splitter component. |
@joaoguilhermeS Great job. https://github.com/langflow-ai/langflow/blob/jg/feat-semantic-text-splitter/src/backend/base/pyproject.toml Can you test adding a different version of langchain_experimental in both? I suggest updating the base pyproject so we won’t need to add it in other pyprojects outside of the base. |
4a6525e
to
afb118d
Compare
Hey @edwinjosechittilappilly, I tested the component with the current langchain-experimental dependency version and it is working just fine, so I think there is no need to update so we do not break other components. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Cristhianzl we might need to update the uvlock accordingly later if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaoguilhermeS if there is no change in the dependencies then I would suggest the uvlock need not be updated.
Apart from that its all good.
8129155
to
c4ba19e
Compare
CodSpeed Performance ReportMerging #4254 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ogabrielluiz I believe you might need to approve for this to get merged.(Since changes requested). Can you take a look into it, Its been blocked from merging. |
aedd0cc
to
0db0ec3
Compare
Feat: Semantic Text Splitter with Advanced Threshold Controls
Overview
Introduces a new Semantic Text Splitter component that provides flexible text chunking with statistical threshold controls and regex support.
Features: