-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests for routes #4249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italojohnny
force-pushed
the
feat/async-api-routes
branch
from
October 23, 2024 12:12
cfd3fca
to
c097058
Compare
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Oct 28, 2024
italojohnny
force-pushed
the
feat/async-api-routes
branch
from
October 28, 2024 13:39
697f059
to
038cf5c
Compare
italojohnny
force-pushed
the
feat/async-api-routes
branch
from
October 28, 2024 13:53
eb86b18
to
5620d45
Compare
ogabrielluiz
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to remove the tests that overlap with these.
You can check test_database.py and some other files in the same level.
italojohnny
force-pushed
the
feat/async-api-routes
branch
from
October 28, 2024 17:26
9d72c14
to
903b9c7
Compare
ogabrielluiz
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to lay the groundwork for changing endpoint dependencies to async, with the goal of improving API performance. To ensure that endpoints don’t break when dependencies are updated, unit tests have been created to cover the happy path for all routes that are not yet async. Additionally, these endpoints have also been converted to async.
The endpoints were identified with the following command: