Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for routes #4249

Merged
merged 75 commits into from
Oct 28, 2024
Merged

test: add unit tests for routes #4249

merged 75 commits into from
Oct 28, 2024

Conversation

italojohnny
Copy link
Member

@italojohnny italojohnny commented Oct 23, 2024

This PR aims to lay the groundwork for changing endpoint dependencies to async, with the goal of improving API performance. To ensure that endpoints don’t break when dependencies are updated, unit tests have been created to cover the happy path for all routes that are not yet async. Additionally, these endpoints have also been converted to async.

The endpoints were identified with the following command:

grep --include="*.py" -nr "^def" -B 1 | grep "@router"

@github-actions github-actions bot added the test Changes to tests label Oct 28, 2024
@italojohnny italojohnny marked this pull request as ready for review October 28, 2024 13:30
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 28, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to remove the tests that overlap with these.
You can check test_database.py and some other files in the same level.

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 28, 2024
@italojohnny italojohnny enabled auto-merge (squash) October 28, 2024 18:14
@italojohnny italojohnny merged commit fadb201 into main Oct 28, 2024
27 checks passed
@italojohnny italojohnny deleted the feat/async-api-routes branch October 28, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. test Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants