-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: home page uplift #4242
Merged
Merged
feat: home page uplift #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Oct 22, 2024
- Remove commented out code and unused imports - Fix indentation and formatting issues in the component
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Oct 23, 2024
- Update grid component in MainPage to use custom navigation hook - Add folderId parameter to editFlowLink in grid component - Update list component in MainPage to use custom navigation hook - Add folderId parameter to editFlowLink in list component Refactor the grid and list components in MainPage to use the custom navigation hook instead of the react-router-dom's useNavigate hook. This allows for better control and customization of navigation within the components. Additionally, the editFlowLink now includes the folderId parameter when navigating to the flow edit page. Closes #<issue_number>
Refactor the grid and list components in the MainPage to improve performance and enhance user experience. This includes updating the styling, optimizing code, and fixing formatting issues.
- Update CSS styles in applies.css to adjust the position of the header notifications dot. - Refactor the button component in button.tsx to fix a typo in the class names. Closes #4259
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:XL
This PR changes 500-999 lines, ignoring generated files.
labels
Oct 24, 2024
…tComponent, dropdown, and button
…lowMenu components
…ge, and HomePage components
- Adjusted the width and height of the SVG element in the EmptyPage component to make it responsive. - Updated the width to "100vw" and the height to "calc(99vh - 62px)". - Also changed the width and height attributes of the rect element to "100%" and "100%" respectively. Fixes #<issue_number>
…New Flow" instead of "New Project"
…New Flow" instead of "New Project"
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Nov 1, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Nov 1, 2024
lucaseduoli
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* refactor: Remove CustomHeader component from AppWrapperPage * refactor: Remove unused code and fix formatting in MainPage component - Remove commented out code and unused imports - Fix indentation and formatting issues in the component * colors update and component building * refactor: Update grid and list components in MainPage - Update grid component in MainPage to use custom navigation hook - Add folderId parameter to editFlowLink in grid component - Update list component in MainPage to use custom navigation hook - Add folderId parameter to editFlowLink in list component Refactor the grid and list components in MainPage to use the custom navigation hook instead of the react-router-dom's useNavigate hook. This allows for better control and customization of navigation within the components. Additionally, the editFlowLink now includes the folderId parameter when navigating to the flow edit page. Closes #<issue_number> * refactor: Update grid and list components in MainPage Refactor the grid and list components in the MainPage to improve performance and enhance user experience. This includes updating the styling, optimizing code, and fixing formatting issues. * Refactor header component to dynamically display folder name * Refactor CSS styles and button component - Update CSS styles in applies.css to adjust the position of the header notifications dot. - Refactor the button component in button.tsx to fix a typo in the class names. Closes langflow-ai#4259 * Refactor folder store and sidebar components * Refactor header component to dynamically toggle folder sidebar visibility * Refactor CSS styles and button component * Refactor CSS styles and button component * Refactor CSS styles to adjust the width of the text container * Refactor dropdown and grid components to handle playground click * Refactor folder sidebar and list components * Refactor CSS styles and components for HeaderMenu, GridComponent, and ListComponent * Refactor CSS styles and components for HeaderMenu, GridComponent, ListComponent, dropdown, and button * Refactor CSS styles to adjust the width of the text container in ListComponent * refactor: Update folder name display in EmptyPage component * refactor: Update folder name display in FlowMenu component * refactor: Update folder name display in AccountMenu and EmptyPage components * refactor: Update folder name display in AccountMenu, EmptyPage, and FlowMenu components * refactor: Update folder name display in AppHeader, DashboardWrapperPage, and HomePage components * refactor: Update folder name display in MainPage components - Update folder name display in AppHeader, DashboardWrapperPage, and HomePage components - Update folder name display in AccountMenu, EmptyPage, and FlowMenu components - Update folder name display in AccountMenu and EmptyPage components - Update folder name display in FlowMenu component - Update folder name display in EmptyPage component Update the folder name display in various components of the MainPage. This ensures that the folder names are correctly displayed in the UI. The affected components include AppHeader, DashboardWrapperPage, HomePage, AccountMenu, EmptyPage, and FlowMenu. This refactor improves the consistency and user experience of the application. * refactor: Update folder name display in EmptyPage and HomePage components * refactor: Update folder name display in AppHeader, DashboardWrapperPage, and HomePage components * refactor: Update folder name display in MainPage components * file organization * Refactor folder name display in MainPage, ListComponent, and HomePage components * Refactor folder name display in MainPage components * test fixes * test fixes part 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to both the backend and frontend of the application, focusing on improving user interface elements, enhancing code maintainability, and fixing minor issues. The most important changes are grouped by theme below.
Backend Changes:
src/backend/base/langflow/worker.py
: Simplified theprocess_graph_cached_task
function by removing its parameters and raising aNotImplementedError
.Frontend Changes:
UI Enhancements:
src/frontend/index.html
: Added a new font (Chivo
) to the project.src/frontend/src/components/appHeaderComponent/components/AccountMenu/index.tsx
: Improved the layout and styling of the account menu, including changing font sizes and adding icons to menu items. [1] [2] [3] [4]src/frontend/src/components/appHeaderComponent/components/FlowMenu/index.tsx
: Enhanced theMenuBar
component with better truncation handling, improved status messages, and more responsive design. [1] [2] [3] [4] [5] [6]Codebase Improvements:
src/frontend/src/alerts/alertDropDown/index.tsx
: AddeduseEffect
to handle the closing of the alert dropdown and added new props for better component control. [1] [2] [3]src/frontend/src/components/appHeaderComponent/components/GithubStarButton/index.tsx
: Introduced a tooltip for the GitHub star button.src/frontend/src/components/appHeaderComponent/components/HeaderMenu/index.tsx
: Added icons to the header menu items and improved the styling. [1] [2] [3] [4] [5]Bug Fixes and Minor Adjustments:
src/frontend/src/components/appHeaderComponent/index.tsx
: Fixed the header positioning and added logic to handle clicks outside the notification dropdown. [1] [2] [3]