ref: Move get services out of API methods #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
cbornet
commented
Oct 20, 2024
| @@ -19,11 +19,11 @@ def post_validate_code(code: Code): | |||
| ) | |||
| except Exception as e: # noqa: BLE001 | |||
| logger.opt(exception=True).debug("Error validating code") | |||
| return HTTPException(status_code=500, detail=str(e)) | |||
| raise HTTPException(status_code=500, detail=str(e)) | |||
There was a problem hiding this comment.
This was incorrect ?
cbornet
force-pushed
the
api-services
branch
2 times, most recently
from
d54aefe
to
d3c38e9
Compare
ogabrielluiz
approved these changes
Oct 21, 2024
|
I had to rollback some changes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't have added value to put
get_xxx_servicemethods inDependsinjections. It even makes the code harder to read.So this PR moves them to the code.
This PR also removes some
response_modelwhen they can be set as the method return type.