fix: object has no attribute 'set_event_manager' #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_event_manager method before calling it
dosubot
bot
added
size:XS
github-actions
bot
added
bug
cbornet
reviewed
Oct 18, 2024
| @@ -495,7 +495,8 @@ async def _build( | |||
| ) | |||
| else: | |||
| custom_component = self._custom_component | |||
| self._custom_component.set_event_manager(event_manager) | |||
| if hasattr(custom_component, "set_event_manager"): | |||
There was a problem hiding this comment.
Or could check that self._custom_component is instance of Component ?
There was a problem hiding this comment.
@cbornet worked as well :)
…adability and maintainability ♻️ (base.py): Refactor code to use isinstance() method for checking if custom_component is an instance of Component
carlosrcoelho
requested review from
edwinjosechittilappilly
and removed request for
ogabrielluiz
| @@ -13,6 +13,7 @@ | |||
| import pandas as pd | |||
| from loguru import logger | |||
|
|
|||
| from langflow.custom import Component | |||
There was a problem hiding this comment.
Expected an Error here from Mypy/ lint since Component was used only for TypeChecking.
But works without error.
@cbornet do we have an exception added for this scenario?
edwinjosechittilappilly
approved these changes
Oct 18, 2024
Cristhianzl
added a commit
that referenced
this pull request
Nov 6, 2024
* fix: update assistants client import (#4150) * remove unnecessary patch * remove unnecessary patch * compatible release operator * chore: add opensearch-py dependency (#4134) Add opensearch-py dependency to pyproject.toml * patch version * lock * lock some packages to speed up pip install * langflow-base version * fix: fix retrieverTool component (#4201) ♻️ (RetrieverTool.py): refactor build method signature to accept additional keyword arguments for future extensibility * Fixed save modal not exiting * fix: object has no attribute 'set_event_manager' (#4200) * 🐛 (base.py): fix AttributeError by checking if custom_component has set_event_manager method before calling it * 📝 (base.py): Import Component from langflow.custom to improve code readability and maintainability ♻️ (base.py): Refactor code to use isinstance() method for checking if custom_component is an instance of Component * Refactor: Eliminate Global Variables for Improved Code Maintainability_fix_release (#4208) Refactor: Eliminate Global Variables for Improved Code Maintainability - Replaced global variables with local variables or class attributes. - Enhanced code readability and reduced potential side effects. * fix: Update example (#4204) update example * fix: avoids error NameError: name 'MAX_NUMBER_OF_FIELDS' is not defin… (#4203) fix: avoids error NameError: name 'MAX_NUMBER_OF_FIELDS' is not defined and fixes build method Co-authored-by: Edwin Jose <[email protected]> * fix: unexpected keyword argument 'code' -> SQLExecutor and SQLDatabase (#4230) 🔧 (SQLDatabase.py): update build method signature to accept additional keyword arguments for future extensibility 🔧 (SQLExecutor.py): update method signature to accept additional keyword arguments for future extensibility * lock httptools to 0.6.4 * Move ChatInput import to within flow_component fixture in conftest.py * Simplify error message formatting in test cases for data components * Add readme to dockerfile * build: dockerfile with entrypoint (#4062) Adds a dockerfile with an entrypoint for use with Datastax Langflow * fixes the leading v for checking out commits correctly * fixes on more version checkout for docker build * ✨ (authContext.tsx): Add functionality to fetch global variables on authentication 🔧 (api.tsx): Replace universal-cookie import with react-cookie for consistency 🔧 (authStore.ts): Replace universal-cookie import with react-cookie for consistency 🔧 (use-get-global-variables.ts): Add check to only fetch global variables if user is authenticated ✨ (use-get-mutation-global-variables.ts): Add mutation function to fetch and update global variables 🔧 (authStore.ts): Replace universal-cookie import with react-cookie for consistency * [autofix.ci] apply automated fixes * revert changes to workflows * upgrade lockfile * update pyproject versions * update lockfile again * ⬆️ (pyproject.toml): upgrade langflow-base dependency to version 0.0.99 * ⬆️ (pyproject.toml): downgrade version from 0.0.99 to 0.0.97 to align with project requirements and dependencies. * ⬆️ (pyproject.toml): downgrade langflow-base dependency version from 0.0.99 to 0.0.97 to resolve compatibility issues * ⬆️ (uv.lock): downgrade langchain-core package version from 0.3.15 to 0.3.12 to resolve compatibility issues with dependencies * ⬆️ (pyproject.toml): upgrade langflow-base dependency to version 0.0.99 to utilize the latest features and improvements --------- Co-authored-by: Sebastián Estévez <[email protected]> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: Lucas Oliveira <[email protected]> Co-authored-by: Edwin Jose <[email protected]> Co-authored-by: anovazzi1 <[email protected]> Co-authored-by: João <[email protected]> Co-authored-by: Jordan Frazier <[email protected]> Co-authored-by: Jordan Frazier <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
joaoguilhermeS
added a commit
that referenced
this pull request
Nov 7, 2024
* fix: update assistants client import (#4150) * remove unnecessary patch * remove unnecessary patch * compatible release operator * chore: add opensearch-py dependency (#4134) Add opensearch-py dependency to pyproject.toml * patch version * lock * lock some packages to speed up pip install * langflow-base version * fix: fix retrieverTool component (#4201) ♻️ (RetrieverTool.py): refactor build method signature to accept additional keyword arguments for future extensibility * Fixed save modal not exiting * fix: object has no attribute 'set_event_manager' (#4200) * 🐛 (base.py): fix AttributeError by checking if custom_component has set_event_manager method before calling it * 📝 (base.py): Import Component from langflow.custom to improve code readability and maintainability ♻️ (base.py): Refactor code to use isinstance() method for checking if custom_component is an instance of Component * Refactor: Eliminate Global Variables for Improved Code Maintainability_fix_release (#4208) Refactor: Eliminate Global Variables for Improved Code Maintainability - Replaced global variables with local variables or class attributes. - Enhanced code readability and reduced potential side effects. * fix: Update example (#4204) update example * fix: avoids error NameError: name 'MAX_NUMBER_OF_FIELDS' is not defin… (#4203) fix: avoids error NameError: name 'MAX_NUMBER_OF_FIELDS' is not defined and fixes build method Co-authored-by: Edwin Jose <[email protected]> * fix: unexpected keyword argument 'code' -> SQLExecutor and SQLDatabase (#4230) 🔧 (SQLDatabase.py): update build method signature to accept additional keyword arguments for future extensibility 🔧 (SQLExecutor.py): update method signature to accept additional keyword arguments for future extensibility * lock httptools to 0.6.4 * Move ChatInput import to within flow_component fixture in conftest.py * Simplify error message formatting in test cases for data components * Add readme to dockerfile * build: dockerfile with entrypoint (#4062) Adds a dockerfile with an entrypoint for use with Datastax Langflow * fixes the leading v for checking out commits correctly * fixes on more version checkout for docker build * ✨ (authContext.tsx): Add functionality to fetch global variables on authentication 🔧 (api.tsx): Replace universal-cookie import with react-cookie for consistency 🔧 (authStore.ts): Replace universal-cookie import with react-cookie for consistency 🔧 (use-get-global-variables.ts): Add check to only fetch global variables if user is authenticated ✨ (use-get-mutation-global-variables.ts): Add mutation function to fetch and update global variables 🔧 (authStore.ts): Replace universal-cookie import with react-cookie for consistency * [autofix.ci] apply automated fixes * revert changes to workflows * upgrade lockfile * update pyproject versions * update lockfile again * ⬆️ (pyproject.toml): upgrade langflow-base dependency to version 0.0.99 * ⬆️ (pyproject.toml): downgrade version from 0.0.99 to 0.0.97 to align with project requirements and dependencies. * ⬆️ (pyproject.toml): downgrade langflow-base dependency version from 0.0.99 to 0.0.97 to resolve compatibility issues * ⬆️ (uv.lock): downgrade langchain-core package version from 0.3.15 to 0.3.12 to resolve compatibility issues with dependencies * ⬆️ (pyproject.toml): upgrade langflow-base dependency to version 0.0.99 to utilize the latest features and improvements --------- Co-authored-by: Sebastián Estévez <[email protected]> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: Lucas Oliveira <[email protected]> Co-authored-by: Edwin Jose <[email protected]> Co-authored-by: anovazzi1 <[email protected]> Co-authored-by: João <[email protected]> Co-authored-by: Jordan Frazier <[email protected]> Co-authored-by: Jordan Frazier <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 (base.py): fix AttributeError by checking if custom_component has set_event_manager method before calling it