ref: Some fixes for ruff rules preview mode #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
cbornet
force-pushed
the
ruff-rules-preview-4
branch
2 times, most recently
from
241119e
to
691e6ca
Compare
cbornet
commented
Oct 19, 2024
| @@ -510,7 +512,7 @@ async def build_vertex( | |||
| lock = chat_service._async_cache_locks[flow_id_str] | |||
| vertex_build_result = await graph.build_vertex( | |||
| vertex_id=vertex_id, | |||
| user_id=current_user.id, | |||
| user_id=str(current_user.id), | |||
There was a problem hiding this comment.
There was a typing error as current.id is an UUID and build_vertex takes a string.
I think it's OK to transform the UUID to string as self._uuid can be both string and UUID in BaseComponent.
WDYT @ogabrielluiz ?
cbornet
force-pushed
the
ruff-rules-preview-4
branch
from
dcdf73c
to
64b62f8
Compare
dosubot
bot
added
size:L
cbornet
force-pushed
the
ruff-rules-preview-4
branch
2 times, most recently
from
8bb38ad
to
7c20927
Compare
cbornet
force-pushed
the
ruff-rules-preview-4
branch
from
7c20927
to
fb418b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for ruff rules preview mode