ref: Add ruff rules for naming (N) #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
cbornet
commented
Oct 17, 2024
| @@ -50,8 +50,8 @@ def build( | |||
| api_key: str, | |||
| url: str, | |||
| timeout: int = 30000, | |||
| crawlerOptions: Data | None = None, | |||
| pageOptions: Data | None = None, | |||
| crawlerOptions: Data | None = None, # noqa: N803 | |||
There was a problem hiding this comment.
I believe it would be breaking to change the field config name ?
cbornet
commented
Oct 17, 2024
| @@ -65,13 +65,13 @@ def validate_flow_id(cls, value): | |||
| return value | |||
|
|
|||
| @field_serializer("flow_id") | |||
| def serialize_flow_id(value): | |||
| def serialize_flow_id(self, value): | |||
There was a problem hiding this comment.
Or could be a staticmethod. Using an instance method for consistency with pydantic docs.
cbornet
commented
Oct 17, 2024
| @@ -111,7 +113,8 @@ def validate_icon_atr(cls, v): | |||
| return v | |||
|
|
|||
| @field_validator("data") | |||
| def validate_json(v): | |||
| @classmethod | |||
| def validate_json(cls, v): | |||
There was a problem hiding this comment.
Or could be a staticmethod. Using a class method for consistency with pydantic's docs.
cbornet
commented
Oct 17, 2024
| @@ -82,7 +82,7 @@ async def log_package_run(self, payload: RunPayload): | |||
| await self._queue_event((self.send_telemetry_data, payload, "run")) | |||
|
|
|||
| async def log_package_shutdown(self): | |||
| payload = ShutdownPayload(timeRunning=(datetime.now(timezone.utc) - self._start_time).seconds) | |||
| payload = ShutdownPayload(time_running=(datetime.now(timezone.utc) - self._start_time).seconds) | |||
| await self._queue_event(payload) | |||
There was a problem hiding this comment.
Shouldn't it go through self.send_telemetry_data ?
There was a problem hiding this comment.
Wow.. I think it should. Good catch.
cbornet
commented
Oct 17, 2024
| "D1", # Missing docstrings | ||
| "N", | ||
| "N999", # Invalid module names |
There was a problem hiding this comment.
All component module names are PascalCase (eg. langflow.components.vectorstores.AstraDB)
I'm not sure if we can change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff rules for naming (N)