Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment variable loading and improve error handling in DB retrieval #4168

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

italojohnny
Copy link
Member

Ensure proper error handling when loading variables from the database

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 15, 2024
@github-actions github-actions bot added the test Changes to tests label Oct 15, 2024
@italojohnny italojohnny changed the title test: rewrite and enable variable loading test fix: environment variable loading and improve error handling in DB retrieval Oct 15, 2024
@github-actions github-actions bot added bug Something isn't working and removed test Changes to tests labels Oct 15, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 16, 2024
@italojohnny italojohnny enabled auto-merge (squash) October 16, 2024 11:22
@ogabrielluiz ogabrielluiz force-pushed the fix/no-silent-errors-db-loading branch from 95c53ac to f3f44c2 Compare October 16, 2024 11:44
@italojohnny italojohnny merged commit 1a72aa7 into main Oct 16, 2024
27 checks passed
@italojohnny italojohnny deleted the fix/no-silent-errors-db-loading branch October 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants