Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch updates and scrolling issues #4167

Merged
merged 8 commits into from
Oct 15, 2024
Merged

fix: batch updates and scrolling issues #4167

merged 8 commits into from
Oct 15, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request includes several commits that address batch updates and scrolling issues in the codebase. The commits introduce changes such as using Flush instead of setTimeout to prevent batch updates, fixing scroll behavior while streaming, and using setTimeout with flushSync for batch updates in buildUtils.ts. These changes aim to improve the performance and functionality of the code.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 15, 2024
@dosubot dosubot bot added the bug Something isn't working label Oct 15, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 15, 2024
autofix-ci bot and others added 5 commits October 15, 2024 20:28
- Pad hours, minutes, and seconds with leading zeros
- Remove AM/PM from the formatted date
- Use 24-hour format for hours in the formatted date

fix: Update session ID generation in IOModal component

- Remove AM/PM from the session ID format
- Use 24-hour format for hours in the session ID
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
Copy link
Contributor

@carlosrcoelho carlosrcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@anovazzi1 anovazzi1 merged commit c9b9fcf into main Oct 15, 2024
25 of 33 checks passed
@anovazzi1 anovazzi1 deleted the fixBatchesOnBuild branch October 15, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants