fix component as a tool #4166

edwinjosechittilappilly · 2024-10-15T20:16:42Z

added class variable is_tool that enable the component to be tool. added basic bool input to turn on/off as tool.
TODO to solve But the toggle doesnt update is_tool as true or changes the output.

src/backend/base/langflow/custom/custom_component/component.py

src/backend/base/langflow/custom/custom_component/custom_component.py

src/backend/base/langflow/inputs/inputs.py

jordanrfrazier · 2024-10-18T17:42:42Z

src/backend/base/langflow/inputs/inputs.py

+        self._previous_value = self.value
+        return self
+
+    def __deepcopy__(self, memo):


Can you explain why this was necessary?

deepcopy was creating issues due to recursion.
Hence overriding that to prevent that issues

This seems potentially very risky, regarding mutable attributes. You're only copying mutable attributes from the BoolInput. However, BaseInputMixin (and the others) also contain mutable attributes.

Future devs that add mutable attributes to these mixins won't know that they need to also update BoolInput, else they risk sharing state between instances.

Let's sync up later and see if there are any alternatives.

I added a fix for deepcopy (it was missing passing memo to the inner deepcopy calls). It is in main already.

jordanrfrazier · 2024-10-22T02:31:04Z

src/backend/base/langflow/components/data/URL.py

@@ -71,7 +72,9 @@ def ensure_url(self, string: str) -> str:
        return string

    def fetch_content(self) -> list[Data]:
-        urls = [self.ensure_url(url.strip()) for url in self.urls if url.strip()]
+        # check if the urls are list or not
+        urls_list = [self.urls] if isinstance(self.urls, str) else self.urls


If self.urls is None, does the below behavior still work? Or do we need to add an explicit None check and return an error?

I agree with Jordan. I'd say a check could be useful to catch unexpected errors. This should never happen but will help us avoid regression.

jordanrfrazier · 2024-10-22T02:32:20Z

src/backend/base/langflow/custom/custom_component/component.py

@@ -17,6 +17,7 @@
 from langflow.helpers.custom import format_type
 from langflow.schema.artifact import get_artifact_type, post_process_raw
 from langflow.schema.data import Data
+from langflow.schema.dotdict import dotdict  # noqa: TCH001


Did you run into an issue putting this in a TYPE_CHECKING block?

Moved to typechecking block

jordanrfrazier · 2024-10-22T02:45:26Z

src/backend/base/langflow/inputs/inputs.py

+        self._previous_value = self.value
+        return self
+
+    def __deepcopy__(self, memo):


This seems potentially very risky, regarding mutable attributes. You're only copying mutable attributes from the BoolInput. However, BaseInputMixin (and the others) also contain mutable attributes.

Future devs that add mutable attributes to these mixins won't know that they need to also update BoolInput, else they risk sharing state between instances.

Let's sync up later and see if there are any alternatives.

ogabrielluiz · 2024-10-22T15:42:55Z

src/backend/base/langflow/inputs/inputs.py

+        self._previous_value = self.value
+        return self
+
+    def __deepcopy__(self, memo):


I added a fix for deepcopy (it was missing passing memo to the inner deepcopy calls). It is in main already.

ogabrielluiz · 2024-10-22T15:43:25Z

src/backend/base/langflow/components/data/URL.py

@@ -71,7 +72,9 @@ def ensure_url(self, string: str) -> str:
        return string

    def fetch_content(self) -> list[Data]:
-        urls = [self.ensure_url(url.strip()) for url in self.urls if url.strip()]
+        # check if the urls are list or not
+        urls_list = [self.urls] if isinstance(self.urls, str) else self.urls


I agree with Jordan. I'd say a check could be useful to catch unexpected errors. This should never happen but will help us avoid regression.

added class variable is_tool that enable the component to be tool. added basic bool input to turn on/off as tool. TOdO to solve But the toggle doesnt update is_tool as true or changes the output.

…efinition - Changed the definition of 'value' to use Field for default value assignment. - Updated 'onChange' to use Field with exclude and repr options. - Ensured that the model configuration allows for assignment validation and arbitrary types. - Added a model validator to check for value changes and trigger the onChange callback.

Tool calling agent may provide a URL component with text data instead of list data. Hence, this is being fixed.

shall update once the Dynamic function is available and utilise the build config to make the update.

moved todict to type checking block

edwinjosechittilappilly · 2024-10-23T19:44:31Z

This PR is Set to draft:
Multiple PR created solving individual issues.

edwinjosechittilappilly requested a review from ogabrielluiz October 15, 2024 20:16

edwinjosechittilappilly marked this pull request as ready for review October 16, 2024 15:15

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 16, 2024

edwinjosechittilappilly requested review from jordanrfrazier and italojohnny October 16, 2024 15:52

jordanrfrazier reviewed Oct 18, 2024

View reviewed changes

edwinjosechittilappilly force-pushed the fix-component-tools branch from 4458645 to 05b48d0 Compare October 21, 2024 19:41

edwinjosechittilappilly requested a review from jordanrfrazier October 21, 2024 22:52

jordanrfrazier requested changes Oct 22, 2024

View reviewed changes

ogabrielluiz requested changes Oct 22, 2024

View reviewed changes

edwinjosechittilappilly mentioned this pull request Oct 22, 2024

refactor: update inputs in ToolCallingAgentComponent and add astream_events setup #4240

Merged

dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 22, 2024

edwinjosechittilappilly and others added 9 commits October 22, 2024 19:46

fix component as a tool

729fb14

added class variable is_tool that enable the component to be tool. added basic bool input to turn on/off as tool. TOdO to solve But the toggle doesnt update is_tool as true or changes the output.

default case to False

2503b32

fix-url component to work with tool calling agent

3c73c0a

Tool calling agent may provide a URL component with text data instead of list data. Hence, this is being fixed.

[autofix.ci] apply automated fixes

6b732ad

updated the reviews

e600f86

[autofix.ci] apply automated fixes

22e119b

formatting issues solved

bdcba79

updates removed: on Change functionality

61bc7ef

shall update once the Dynamic function is available and utilise the build config to make the update.

edwinjosechittilappilly force-pushed the fix-component-tools branch from 2d62b1a to 61bc7ef Compare October 22, 2024 23:46

Solves Error : Tools not receiving inputs in required format

02c84d2

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 23, 2024

Update component.py

aa40982

moved todict to type checking block

edwinjosechittilappilly requested review from ogabrielluiz and jordanrfrazier October 23, 2024 18:41

Merge branch 'main' into fix-component-tools

6b00c5c

edwinjosechittilappilly marked this pull request as draft October 23, 2024 19:02

edwinjosechittilappilly closed this Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix component as a tool #4166

fix component as a tool #4166

edwinjosechittilappilly commented Oct 15, 2024 •

edited

Loading

jordanrfrazier Oct 18, 2024

edwinjosechittilappilly Oct 18, 2024

jordanrfrazier Oct 22, 2024

ogabrielluiz Oct 22, 2024

jordanrfrazier Oct 22, 2024

ogabrielluiz Oct 22, 2024

jordanrfrazier Oct 22, 2024

edwinjosechittilappilly Oct 23, 2024

jordanrfrazier Oct 22, 2024

ogabrielluiz Oct 22, 2024

ogabrielluiz Oct 22, 2024

edwinjosechittilappilly commented Oct 23, 2024

fix component as a tool #4166

fix component as a tool #4166

Conversation

edwinjosechittilappilly commented Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edwinjosechittilappilly commented Oct 23, 2024

edwinjosechittilappilly commented Oct 15, 2024 •

edited

Loading