-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Fix some ruff rules for private access (SLF) #4139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dangerous one. hahaha
fcc0b29
to
2aabe76
Compare
Yes, I'm counting on you to know the places where there are traps like |
Can't rename |
026f899
to
b5bb22a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
10989d7
to
d7a5f4a
Compare
45377b5
to
6f45b59
Compare
6f45b59
to
6af5bf7
Compare
Fixing but not enforcing at the moment since a lot of attributes can't be changed in Component
Renamed: