Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: name/description bug in "Flow as Tool" #4096

Closed
wants to merge 0 commits into from
Closed

fix: name/description bug in "Flow as Tool" #4096

wants to merge 0 commits into from

Conversation

dhlidongming
Copy link
Contributor

This pull request addresses a bug in the Flow as Tool where the name and description were incorrectly fetched directly from self.name and self.description. This resulted in retrieving the attributes of Flow as Tool itself rather than the user-provided values in the input fields.
This change ensures that the correct user-provided data is used for the name and description, aligning their behavior with how flow_name is accessed.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Oct 10, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 10, 2024
ogabrielluiz
ogabrielluiz requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dhlidongming

Good catch. Thanks for this

src/backend/base/langflow/components/prototypes/FlowTool.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to change the name of the inputs to tool_name and tool_description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogabrielluiz I completely agree with your revisions, and I have initiated a new pull request: @4097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz requested changes

Assignees
No one assigned
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhlidongming @ogabrielluiz