Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NameError for Vertex and Graph Imports in Flow Tool #4054

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

Debugging and Fix for NameError

Summary

This PR addresses a NameError related to the Vertex and Graph classes not being defined. The issue arose because both imports were placed within the TYPE_CHECKING block, which prevents them from being available at runtime.

Changes Made

  • Moved the imports for Vertex and Graph outside of the TYPE_CHECKING block to ensure they are accessible during execution.
  • Added additional debugging to further investigate the underlying issue.

Next Steps

  • Further debugging is needed to fully resolve the issue and ensure stability.

- Removed unnecessary imports from TYPE_CHECKING block.
- Cleaned up import statements for better readability and organization.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Oct 7, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 7, 2024
@jordanrfrazier jordanrfrazier enabled auto-merge (squash) October 7, 2024 19:37
@jordanrfrazier jordanrfrazier merged commit 4ed00cd into main Oct 7, 2024
37 of 44 checks passed
@jordanrfrazier jordanrfrazier deleted the fix-type-checking-errors-run_flow_tool branch October 7, 2024 19:42
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…#4054)

* Update flow_tool.py

- Removed unnecessary imports from TYPE_CHECKING block.
- Cleaned up import statements for better readability and organization.

* Update flow_tool.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants