Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use TypeError instead of ValueError when relevant (TRY004) #4045

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 7, 2024

Use TypeError instead of ValueError when relevant (TRY004)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 7, 2024
@cbornet cbornet requested a review from ogabrielluiz October 7, 2024 15:03
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4045.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@cbornet cbornet force-pushed the ruff-rules-typeerror branch 4 times, most recently from dfad07b to 526e2fc Compare October 8, 2024 18:36
@cbornet cbornet force-pushed the ruff-rules-typeerror branch from 526e2fc to f9e1b64 Compare October 8, 2024 18:42
@cbornet cbornet enabled auto-merge (squash) October 8, 2024 18:43
@cbornet cbornet disabled auto-merge October 8, 2024 19:02
@cbornet cbornet enabled auto-merge (squash) October 8, 2024 19:02
@cbornet cbornet merged commit ba6838c into langflow-ai:main Oct 8, 2024
29 checks passed
@cbornet cbornet deleted the ruff-rules-typeerror branch October 8, 2024 19:26
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…flow-ai#4045)

Use TypeError instead of ValueError when relevant (TRY004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants