ref: Add ruff rules for pygrep-hooks (PGH) #4042
Conversation
dosubot
bot
added
the
size:L
| @@ -10,8 +10,8 @@ | |||
| import httpx | |||
| import typer | |||
| from dotenv import load_dotenv | |||
| from multiprocess import cpu_count # type: ignore | |||
There was a problem hiding this comment.
There are a lot of # type: ignore on 3rd party dependencies.
I guess those are optional ?
But shouldn't mypy be run with uv's dev deps that contain those dependencies ?
There was a problem hiding this comment.
This case is because multiprocess is kinda weird. I'm not sure about the other ones but they generally are related to typing variables and outputs inside components. Not a lot of people know about cast and how to type correctly.
There was a problem hiding this comment.
I think you get these mypy errors when you don't have the dependency.
In CI dev dependencies are installed and mypy still passes when removing the ignore.
There was a problem hiding this comment.
multiprocess is a base dependency in langflow
There was a problem hiding this comment.
Then. I don't know why this ignore was there. Maybe some legacy ?
There was a problem hiding this comment.
Process is not explicitly exported in multiprocess.init
There was a problem hiding this comment.
It doesn't raise an error in mypy for me. Does it for you ?
Maybe we can check if CI passes ?
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cbornet
force-pushed
the
ruff-rules-pgh
branch
3 times, most recently
from
b815b1c to
7c0f7f7
Compare
cbornet
force-pushed
the
ruff-rules-pgh
branch
from
7c0f7f7 to
1d38aed
Compare
Add ruff rules for pygrep-hooks (PGH)
Add ruff rules for pygrep-hooks (PGH)