ref: Fix ruff rules in preview mode #4039
Conversation
dosubot
bot
added
the
size:L
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cbornet
force-pushed
the
ruff-rules-preview
branch
from
8a72c66 to
9d0970a
Compare
| #! This part here is clunky but we need it like this for | ||
| #! backwards compatibility. We can change how prompt component | ||
| #! works and then update this later | ||
| # ! This part here is clunky but we need it like this for |
There was a problem hiding this comment.
Is the comment syntax #! used by something ? (conflicts with shebang btw) ?
There was a problem hiding this comment.
Not really. I use https://marketplace.visualstudio.com/items?itemName=aaron-bond.better-comments and that makes it pop a bit more but not necessary. It is just to make sure people pay attention to certain comments more than others.
There was a problem hiding this comment.
Does it still highlight if you have a space before the ! ?
There was a problem hiding this comment.
I think it should work and is recommended to have the space: aaron-bond/better-comments#8 (comment)
There was a problem hiding this comment.
Go for it. Thanks for the heads up!
cbornet
force-pushed
the
ruff-rules-preview
branch
3 times, most recently
from
05d4bf8 to
16de7e1
Compare
|
Added support for |
cbornet
force-pushed
the
ruff-rules-preview
branch
from
16de7e1 to
7c41224
Compare
cbornet
force-pushed
the
ruff-rules-preview
branch
from
7c41224 to
11fb7c8
Compare
cbornet
force-pushed
the
ruff-rules-preview
branch
from
11fb7c8 to
7403f2b
Compare
Fix some ruff rules from preview mode
Fix ruff rules in preview mode.
Note: we don't use preview mode in CI (for good reason)