fix: set folder id on flows imported on startup #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
github-actions
bot
added
bug
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
requested changes
Oct 4, 2024
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* set folder id on flows imported on startup --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
LANGFLOW_LOAD_FLOWS_PATHto import flows on startup did not set thefolder_idcorrectly, causing flows to be orphaned in the frontend, with no way to display them. Theapi/v1/flowsstill lists them, which is why it originally was considered working.This PR adds
folder_idto both existing orphaned flows and newly created flows.Note that the current behavior just uses the default_folder as the folder. Ideally, as per #4010, we'd have the ability to scope flows to folders and users. This PR is the first step so as to unblock users from the basic functionality.