Add ruff rules for TYPE_CHECKING (TCH) #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
cbornet
force-pushed
the
ruff-rules-tch
branch
from
763be9b to
7b6d66c
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
approved these changes
Oct 3, 2024
|
Putting this on hold as FastAPI annotations need runtime evaluation and I couldn't make |
cbornet
force-pushed
the
ruff-rules-tch
branch
from
77e1675 to
6db6f52
Compare
cbornet
force-pushed
the
ruff-rules-tch
branch
from
6db6f52 to
2a16f39
Compare
cbornet
force-pushed
the
ruff-rules-tch
branch
from
2a16f39 to
bc9c1f0
Compare
cbornet
commented
Oct 4, 2024
| @@ -198,6 +204,11 @@ ignore = [ | |||
| "ISC001", # Messes with the formatter | |||
| ] | |||
|
|
|||
| [tool.ruff.lint.per-file-ignores] | |||
| "langflow/api/v1/*" = [ | |||
| "TCH", # FastAPI needs to evaluate types at runtime | |||
There was a problem hiding this comment.
I had to ignore here. Ideally we would use flake8-type-checking.runtime-evaluated-decorators but I couldn't make it work with fastapi's APIRouter annotations without importing the router from a separate file. This looks like a bug in ruff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.